Skip to content

8322725: (tz) Update Timezone Data to 2023d#17268

Closed
johnyjose30 wants to merge 1 commit intoopenjdk:masterfrom
johnyjose30:JDK-8322725
Closed

8322725: (tz) Update Timezone Data to 2023d#17268
johnyjose30 wants to merge 1 commit intoopenjdk:masterfrom
johnyjose30:JDK-8322725

Conversation

@johnyjose30
Copy link
Contributor

@johnyjose30 johnyjose30 commented Jan 4, 2024

tzdata2023d changes


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322725: (tz) Update Timezone Data to 2023d (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17268/head:pull/17268
$ git checkout pull/17268

Update a local copy of the PR:
$ git checkout pull/17268
$ git pull https://git.openjdk.org/jdk.git pull/17268/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17268

View PR using the GUI difftool:
$ git pr show -t 17268

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17268.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2024

👋 Welcome back johnyjose30! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@johnyjose30 The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jan 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 4, 2024

Webrevs

@johnyjose30
Copy link
Contributor Author

@naotoj Can you please review the changes

@johnyjose30
Copy link
Contributor Author

johnyjose30 commented Jan 4, 2024

/reviewer credit @coffeys @naotoj

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@johnyjose30 Syntax: /reviewer (credit|remove) [@user | openjdk-user]+. For example:

  • /reviewer credit @openjdk-bot
  • /reviewer credit duke
  • /reviewer credit @user1 @user2

Copy link
Contributor

@coffeys coffeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@johnyjose30 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322725: (tz) Update Timezone Data to 2023d

Reviewed-by: coffeys, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • 5235cc9: 8322583: RISC-V: Enable fast class initialization checks
  • 3b1e56a: 8322322: Support archived full module graph when -Xbootclasspath/a is used
  • 3fbccb0: 8322978: Remove debug agent debugMonitorTimedWait() function. It is no longer used.
  • ad31ec5: 8322647: Short name for the Europe/Lisbon time zone is incorrect
  • 15cf8f8: 8319626: Override toString() for ZipFile
  • ade4074: 8322976: Remove reference to transform_no_reclaim
  • ea19e9c: 8323011: ProblemList serviceability/HeapDump/FullGCHeapDumpLimitTest.java
  • d33dfe5: 8323002: test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java times out on macosx-x64
  • 27d5f5c: 8322781: C1: Debug build crash in GraphBuilder::vmap() when print stats
  • df22fb3: 8322512: StringBuffer.repeat does not work correctly after toString() was called
  • ... and 24 more: https://git.openjdk.org/jdk/compare/ba426d6887bc2d7e2b39f1b19cc1d8d8f14cfb45...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys, @naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 4, 2024
Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM too, assuming all the tests passed

@johnyjose30
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 5, 2024
@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@johnyjose30
Your change (at version 745a2ad) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Jan 5, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

Going to push as commit 2a9c358.
Since your change was applied there have been 34 commits pushed to the master branch:

  • 5235cc9: 8322583: RISC-V: Enable fast class initialization checks
  • 3b1e56a: 8322322: Support archived full module graph when -Xbootclasspath/a is used
  • 3fbccb0: 8322978: Remove debug agent debugMonitorTimedWait() function. It is no longer used.
  • ad31ec5: 8322647: Short name for the Europe/Lisbon time zone is incorrect
  • 15cf8f8: 8319626: Override toString() for ZipFile
  • ade4074: 8322976: Remove reference to transform_no_reclaim
  • ea19e9c: 8323011: ProblemList serviceability/HeapDump/FullGCHeapDumpLimitTest.java
  • d33dfe5: 8323002: test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java times out on macosx-x64
  • 27d5f5c: 8322781: C1: Debug build crash in GraphBuilder::vmap() when print stats
  • df22fb3: 8322512: StringBuffer.repeat does not work correctly after toString() was called
  • ... and 24 more: https://git.openjdk.org/jdk/compare/ba426d6887bc2d7e2b39f1b19cc1d8d8f14cfb45...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 5, 2024
@openjdk openjdk bot closed this Jan 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 5, 2024
@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@coffeys @johnyjose30 Pushed as commit 2a9c358.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lutkerd
Copy link
Contributor

lutkerd commented Jan 5, 2024

/backport jdk22

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@lutkerd To use the /backport command, you need to be in the OpenJDK census and your GitHub account needs to be linked with your OpenJDK username (how to associate your GitHub account with your OpenJDK username).

@lutkerd
Copy link
Contributor

lutkerd commented Jan 5, 2024

/backport jdk17u-dev

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@lutkerd the backport was successfully created on the branch backport-lutkerd-2a9c3589 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 2a9c3589 from the openjdk/jdk repository.

The commit being backported was authored by Johny Jose on 5 Jan 2024 and was reviewed by Sean Coffey and Naoto Sato.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git backport-lutkerd-2a9c3589:backport-lutkerd-2a9c3589
$ git checkout backport-lutkerd-2a9c3589
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git backport-lutkerd-2a9c3589

@lutkerd
Copy link
Contributor

lutkerd commented Jan 5, 2024

/backport jdk11u-dev

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@lutkerd the backport was successfully created on the branch backport-lutkerd-2a9c3589 in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 2a9c3589 from the openjdk/jdk repository.

The commit being backported was authored by Johny Jose on 5 Jan 2024 and was reviewed by Sean Coffey and Naoto Sato.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev.git backport-lutkerd-2a9c3589:backport-lutkerd-2a9c3589
$ git checkout backport-lutkerd-2a9c3589
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev.git backport-lutkerd-2a9c3589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants