8326334: JFR failed assert(used(klass)) failed: invariant

[mgronlun]

Greetings,

please help review this adjustment for the JFR typeset class unloading logic.

Testing: jdk_jfr

Thanks
Markus

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326334: JFR failed assert(used(klass)) failed: invariant (Bug - P3)

Reviewers

• Erik Gahlin (@egahlin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17934/head:pull/17934
$ git checkout pull/17934

Update a local copy of the PR:
$ git checkout pull/17934
$ git pull https://git.openjdk.org/jdk.git pull/17934/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17934

View PR using the GUI difftool:
$ git pr show -t 17934

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17934.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mgronlun The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3993ae8c)

[openjdk]

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326334: JFR failed assert(used(klass)) failed: invariant

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 112 new commits pushed to the master branch:

• 492e8bf: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM
• 5f16f34: 8326370: Remove redundant and misplaced micros from StringBuffers
• 921507c: 8326319: G1: Remove unused G1ConcurrentMark::_init_times
• 68eb5a1: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support
• 04d43c4: 8187759: Background not refreshed when painting over a transparent JFrame
• d5f3d5c: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
• d31fd78: 8325496: Make TrimNativeHeapInterval a product switch
• 27003b5: 8326090: Rename jvmti_aod.h
• 36246c9: 8326233: Utils#copySSLParameters loses needClientAuth Setting
• 14f9aba: 8326371: [BACKOUT] Clean up NativeCompilation.gmk and its newly created parts
• ... and 102 more: https://git.openjdk.org/jdk/compare/f8d8eecf8041a8baa76ba0091f2842dcb0275cb3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mgronlun]

/integrate

[openjdk]

Going to push as commit 2352268.
Since your change was applied there have been 112 commits pushed to the master branch:

• 492e8bf: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM
• 5f16f34: 8326370: Remove redundant and misplaced micros from StringBuffers
• 921507c: 8326319: G1: Remove unused G1ConcurrentMark::_init_times
• 68eb5a1: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support
• 04d43c4: 8187759: Background not refreshed when painting over a transparent JFrame
• d5f3d5c: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
• d31fd78: 8325496: Make TrimNativeHeapInterval a product switch
• 27003b5: 8326090: Rename jvmti_aod.h
• 36246c9: 8326233: Utils#copySSLParameters loses needClientAuth Setting
• 14f9aba: 8326371: [BACKOUT] Clean up NativeCompilation.gmk and its newly created parts
• ... and 102 more: https://git.openjdk.org/jdk/compare/f8d8eecf8041a8baa76ba0091f2842dcb0275cb3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mgronlun Pushed as commit 2352268.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.