JDK-8327988: When running ASAN, disable dangerous NMT test#18237
JDK-8327988: When running ASAN, disable dangerous NMT test#18237tstuefe wants to merge 6 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
|
@tstuefe To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
b36191c to
ae59e6c
Compare
ae59e6c to
fcba3f2
Compare
|
❗ This change is not yet ready to be integrated. |
|
Closed, will be part of #18230 |
NMT gtests trigger ASAN for several reasons. Issues like printing malloc blocks (which we do, carefully, with SafeFetch), or corner case tests for malloc with sizes ASAN thinks are invalid.
All these tests should just be disabled when building with ASAN support.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18237/head:pull/18237$ git checkout pull/18237Update a local copy of the PR:
$ git checkout pull/18237$ git pull https://git.openjdk.org/jdk.git pull/18237/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18237View PR using the GUI difftool:
$ git pr show -t 18237Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18237.diff