Skip to content

JDK-8327988: When running ASAN, disable dangerous NMT test#18237

Closed
tstuefe wants to merge 6 commits intoopenjdk:masterfrom
tstuefe:JDK-8327988-When-running-ASAN-disable-dangerous-NMT-test
Closed

JDK-8327988: When running ASAN, disable dangerous NMT test#18237
tstuefe wants to merge 6 commits intoopenjdk:masterfrom
tstuefe:JDK-8327988-When-running-ASAN-disable-dangerous-NMT-test

Conversation

@tstuefe
Copy link
Copy Markdown
Member

@tstuefe tstuefe commented Mar 12, 2024

NMT gtests trigger ASAN for several reasons. Issues like printing malloc blocks (which we do, carefully, with SafeFetch), or corner case tests for malloc with sizes ASAN thinks are invalid.

All these tests should just be disabled when building with ASAN support.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327988: When running ASAN, disable dangerous NMT test (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18237/head:pull/18237
$ git checkout pull/18237

Update a local copy of the PR:
$ git checkout pull/18237
$ git pull https://git.openjdk.org/jdk.git pull/18237/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18237

View PR using the GUI difftool:
$ git pr show -t 18237

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18237.diff

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 12, 2024

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 12, 2024

@tstuefe To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@tstuefe tstuefe force-pushed the JDK-8327988-When-running-ASAN-disable-dangerous-NMT-test branch from b36191c to ae59e6c Compare March 13, 2024 08:38
@tstuefe tstuefe force-pushed the JDK-8327988-When-running-ASAN-disable-dangerous-NMT-test branch from ae59e6c to fcba3f2 Compare March 13, 2024 08:40
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 13, 2024
@tstuefe
Copy link
Copy Markdown
Member Author

tstuefe commented Mar 20, 2024

Closed, will be part of #18230

@tstuefe tstuefe closed this Mar 20, 2024
@tstuefe tstuefe deleted the JDK-8327988-When-running-ASAN-disable-dangerous-NMT-test branch March 20, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant