8328561: test java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used

[prrace]

I don't know why this file is checked in. It has no @test tag and doesn't do anything. I am deleting it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328561: test java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used (Bug - P4)

Reviewers

• Damon Nguyen (@DamonGuy - Committer)
• Prasanta Sadhukhan (@prsadhuk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18440/head:pull/18440
$ git checkout pull/18440

Update a local copy of the PR:
$ git checkout pull/18440
$ git pull https://git.openjdk.org/jdk.git pull/18440/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18440

View PR using the GUI difftool:
$ git pr show -t 18440

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18440.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328561: test java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used

Reviewed-by: dnguyen, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 184 new commits pushed to the master branch:

• df01cc5: 8323576: [Windows] Fallthrough to ::abort instead of os::infinite_sleep for noreturn methods
• bf93e77: 8329118: Run MessageFormat additional subformat pattern tests under en_US locale
• 991e04e: 8327383: Clean up _Stalled and _Spinner fields
• 4eefda9: 8327779: Remove deprecated internal field sun.security.x509.X509Key.key
• 341dd57: 8325883: Move Monitor Deflation reporting out of safepoint cleanup
• 7ac2f91: 8329210: Delete Redundant Printer Dialog Modality Test
• 85cb4a9: 8247449: Revisit the argument processing logic for MetaspaceShared::disable_optimized_module_handling()
• aa595db: 8328507: Move StackWatermark code from safepoint cleanup
• 2af0312: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use
• 7c7b961: 8329191: JVMCI compiler warning is truncated
• ... and 174 more: https://git.openjdk.org/jdk/compare/0204aacb0305e94a7d6d5299a5ae835f3f71b030...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (75bac5f6)

[prsadhuk]

Should we also remove test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ModifierPermutation.java which also does not have @test tag and added for same product fix JDK-6315717?

[prrace]

Should we also remove test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ModifierPermutation.java which also does not have @test tag and added for same product fix JDK-6315717?

Whilst the test in that file clearly needs some work, it (1) isn't related to Applets and (2) does appear to be actually related to the product fix. So I think deciding what to do with that is a separate question. We might want to fix it up and get it running in CI testing.

[prsadhuk]

ok

[prrace]

/integrate

[openjdk]

Going to push as commit bc546c2.
Since your change was applied there have been 205 commits pushed to the master branch:

• af7c6af: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3
• d3fc8df: 8329135: Store Universe::*exception_instance() in CDS archive
• a85c849: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use
• 70c8ff1: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout
• ecd2b71: 8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails
• c2979c1: 8329425: ProblemList containers/docker/TestJFREvents.java on linux-x64
• 5698f7a: 8329134: Reconsider TLAB zapping
• 4a14cba: 8329213: Better validation for com.sun.security.ocsp.useget option
• 9f5464e: 8329353: ResolvedReferencesNotNullTest.java failed with Incorrect resolved references array, quxString should not be archived
• 3f5b75a: 8328541: Remove or update obsolete comment in JRootPane
• ... and 195 more: https://git.openjdk.org/jdk/compare/0204aacb0305e94a7d6d5299a5ae835f3f71b030...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit bc546c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.