8331591: sun.font.CharSequenceCodePointIterator is buggy and unused#19072
8331591: sun.font.CharSequenceCodePointIterator is buggy and unused#19072prrace wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
honkar-jdk
left a comment
There was a problem hiding this comment.
Cleanup looks good. No other usages of CharSequenceCodePointIterator except in this file. Build works fine too.
Minor: Copyright year needs to be updated.
|
/integrate |
|
Going to push as commit 36c9607.
Your commit was automatically rebased without conflicts. |
Delete an internal class that has been around for 20 years but never been used.
Verified that is true at least as far back as JDK7
All platforms build. Tests pass.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19072/head:pull/19072$ git checkout pull/19072Update a local copy of the PR:
$ git checkout pull/19072$ git pull https://git.openjdk.org/jdk.git pull/19072/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19072View PR using the GUI difftool:
$ git pr show -t 19072Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19072.diff
Webrev
Link to Webrev Comment