Skip to content

8331591: sun.font.CharSequenceCodePointIterator is buggy and unused#19072

Closed
prrace wants to merge 2 commits intoopenjdk:masterfrom
prrace:unused
Closed

8331591: sun.font.CharSequenceCodePointIterator is buggy and unused#19072
prrace wants to merge 2 commits intoopenjdk:masterfrom
prrace:unused

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented May 2, 2024

Delete an internal class that has been around for 20 years but never been used.
Verified that is true at least as far back as JDK7
All platforms build. Tests pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331591: sun.font.CharSequenceCodePointIterator is buggy and unused (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19072/head:pull/19072
$ git checkout pull/19072

Update a local copy of the PR:
$ git checkout pull/19072
$ git pull https://git.openjdk.org/jdk.git pull/19072/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19072

View PR using the GUI difftool:
$ git pr show -t 19072

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19072.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2024

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 2, 2024

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331591: sun.font.CharSequenceCodePointIterator is buggy and unused

Reviewed-by: angorya, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 01125fa: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
  • 04271df: 8331331: :tier1 target explanation in doc/testing.md is incorrect
  • f6cdcc6: 8280988: [XWayland] Click on title to request focus test failures
  • 99654ec: 8331516: Tests should not use the "Classpath" exception form of the legal header
  • cd3a607: 8328864: NullPointerException in sun.security.jca.ProviderList.getService()
  • 73cdc9a: 8326421: Add jtreg test for large arrayCopy disjoint case.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8331591 8331591: sun.font.CharSequenceCodePointIterator is buggy and unused May 2, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label May 2, 2024
@openjdk
Copy link

openjdk bot commented May 2, 2024

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 2, 2024
@mlbridge
Copy link

mlbridge bot commented May 2, 2024

Webrevs

Copy link

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup looks good. No other usages of CharSequenceCodePointIterator except in this file. Build works fine too.
Minor: Copyright year needs to be updated.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 2, 2024
@prrace
Copy link
Contributor Author

prrace commented May 3, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 3, 2024

Going to push as commit 36c9607.
Since your change was applied there have been 25 commits pushed to the master branch:

  • b33096f: 8295153: java/util/Base64/TestEncodingDecodingLength.java ran out of memory
  • cf2c80e: 8331582: Incorrect default Console provider comment
  • 77b7122: 8312104: Update java man pages to include new security category in -XshowSettings
  • 87bb66c: 8331569: G1: Rename G1HRPrinter to G1HeapRegionPrinter
  • 37c2469: 8331633: Use MIN2 in bound_minus_alignment
  • 1d083eb: 8331562: G1: Remove API to force allocation of new regions
  • 9697bc3: 8331428: ubsan: JVM flag checking complains about MaxTenuringThresholdConstraintFunc, InitialTenuringThresholdConstraintFunc and AllocatePrefetchStepSizeConstraintFunc
  • ce73fec: 8331048: G1: Prune rebuild candidates based on G1HeapWastePercent early
  • 58ef9e4: 8331402: G1: Remove is_active() calls in G1HRPrinter logging
  • 3c77dad: 8331507: JFR: Improve example usage in -XX:StartFlightRecording:help
  • ... and 15 more: https://git.openjdk.org/jdk/compare/e2c0cfef1468e1081d1e68f74caae71266815cb6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 3, 2024
@openjdk openjdk bot closed this May 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 3, 2024
@openjdk
Copy link

openjdk bot commented May 3, 2024

@prrace Pushed as commit 36c9607.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants