Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8196466: javax/swing/JFileChooser/8062561/bug8062561.java fails #1924

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jan 4, 2021

This test was marked for "windows only" in 7cb9e58 in JDK-8198333
but the test is redundantly problem listed for linux and mac.
We can remove the test from ProblemList as it is being run in mach5 on windows without any issue and it will not run on linux,mac as 8062561 fix for which this test was created is windows specific.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8196466: javax/swing/JFileChooser/8062561/bug8062561.java fails

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1924/head:pull/1924
$ git checkout pull/1924

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 4, 2021
@openjdk
Copy link

openjdk bot commented Jan 4, 2021

@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@prsadhuk
Copy link
Contributor Author

prsadhuk commented Jan 4, 2021

/label add swing

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Jan 4, 2021
@openjdk
Copy link

openjdk bot commented Jan 4, 2021

@prsadhuk
The swing label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jan 4, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 4, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8196466: javax/swing/JFileChooser/8062561/bug8062561.java fails

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 4, 2021
@prsadhuk
Copy link
Contributor Author

prsadhuk commented Jan 4, 2021

/integrate

@openjdk openjdk bot closed this Jan 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 4, 2021
@openjdk
Copy link

openjdk bot commented Jan 4, 2021

@prsadhuk Pushed as commit d679caa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the 8196466 branch January 4, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
2 participants