8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded

[tschatzl]

Hi all,

please review this change to exclude the watermark tests from use with -Xcomp.

The failures reported are related to -Xcomp triggering the wrong kind of garbage collection pauses (CodeCache related GCs instead of Metadata related GCs) the test then fails on.

The proposed solution is to just disable the tests with -Xcomp: the tests are not related to compilation at all.

Testing: local, gha

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded (Bug - P3)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19421/head:pull/19421
$ git checkout pull/19421

Update a local copy of the PR:
$ git checkout pull/19421
$ git pull https://git.openjdk.org/jdk.git pull/19421/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19421

View PR using the GUI difftool:
$ git pr show -t 19421

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19421.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded

Reviewed-by: stefank, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 6d718ae: 8324341: Remove redundant preprocessor #if's checks
• 9b64ece: 8332904: ubsan ppc64le: c1_LIRGenerator_ppc.cpp:581:21: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long int'
• 3d4eb15: 8302744: Refactor Hotspot container detection code
• 2cca83b: 8332880: JFR GCHelper class recognizes "Archive" regions as valid
• b8ae11e: 8332960: ubsan: classListParser.hpp:159:12: runtime error: load of value 2101478704, which is not a valid value for type 'ParseMode'
• 9a83dfe: 8332431: NullPointerException in JTable of SwingSet2
• 01060ad: 8325083: jdk/incubator/vector/Double512VectorTests.java crashes in Assembler::vex_prefix_and_encode
• 673f767: 8285506: Unify os::vsnprintf implementations
• 91ab088: 8333116: test/jdk/tools/jpackage/share/ServiceTest.java test fails
• 9ac8d05: 8332228: TypePollution.java: Unrecognized VM option 'UseSecondarySuperCache'
• ... and 11 more: https://git.openjdk.org/jdk/compare/2edb6d98133d8bd6dc4527c7497c460283fdc53e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (603f6272)

[tschatzl]

Thanks @stefank @albertnetymk for your reviews
/integrate

[openjdk]

Going to push as commit 5ed0d52.
Since your change was applied there have been 94 commits pushed to the master branch:

• 91101f0: 8333353: Delete extra empty line in CodeBlob.java
• e0ac824: 8332959: C2: ZGC fails with 'Incorrect load shift' when invoking Object.clone() reflectively on an array
• d2d78ad: 8280990: [XWayland] XTest emulated mouse click does not bring window to front
• 7c83d7a: 8333366: C2: CmpU3Nodes are not pushed back to worklist in PhaseCCP leading to non-fixpoint assertion failure
• 75220da: 8333154: RISC-V: Add support for primitive array C1 clone intrinsic
• a4c7be8: 8333006: RISC-V: C2: Support vector-scalar and vector-immediate arithmetic instructions
• cfe91ed: 8333276: RISC-V: client VM build failure after JDK-8241503
• 769b3e4: 8333182: Add truncated tracing mode for TraceBytecodes
• 8338946: 8332935: Crash: assert(*lastPtr != 0) failed: Mismatched JNINativeInterface tables, check for new entries
• 4785461: 7022325: TEST_BUG: test/java/util/zip/ZipFile/ReadLongZipFileName.java leaks files if it fails
• ... and 84 more: https://git.openjdk.org/jdk/compare/2edb6d98133d8bd6dc4527c7497c460283fdc53e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 5ed0d52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.