-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8336012: Fix usages of jtreg-reserved properties #20099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8336012: Fix usages of jtreg-reserved properties #20099
Conversation
|
👋 Welcome back cstein! A progress list of the required criteria for merging this PR into |
|
@sormuras This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit e6c5aa7.
Your commit was automatically rebased without conflicts. |
Please review this trivial test-only change to resolve a name clash with a jtreg-reserved property by removing the third option to control a test verbosity level via the
test.verbosesystem property.The fix assumes that the system property was only used in a manual scenario, like
make test TEST=...and a-Dtest.verbose=99equivalent. For such scenarios, the other two names (for example-DPrivateInvokeTest.verbose=99) are still supported.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20099/head:pull/20099$ git checkout pull/20099Update a local copy of the PR:
$ git checkout pull/20099$ git pull https://git.openjdk.org/jdk.git pull/20099/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20099View PR using the GUI difftool:
$ git pr show -t 20099Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20099.diff
Webrev
Link to Webrev Comment