Skip to content

8336012: Fix usages of jtreg-reserved properties#20099

Closed
sormuras wants to merge 1 commit intoopenjdk:masterfrom
sormuras:JDK-8336012-jtreg-reserved-property
Closed

8336012: Fix usages of jtreg-reserved properties#20099
sormuras wants to merge 1 commit intoopenjdk:masterfrom
sormuras:JDK-8336012-jtreg-reserved-property

Conversation

@sormuras
Copy link
Member

@sormuras sormuras commented Jul 9, 2024

Please review this trivial test-only change to resolve a name clash with a jtreg-reserved property by removing the third option to control a test verbosity level via the test.verbose system property.

The fix assumes that the system property was only used in a manual scenario, like make test TEST=... and a -Dtest.verbose=99 equivalent. For such scenarios, the other two names (for example -DPrivateInvokeTest.verbose=99) are still supported.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8336012: Fix usages of jtreg-reserved properties (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20099/head:pull/20099
$ git checkout pull/20099

Update a local copy of the PR:
$ git checkout pull/20099
$ git pull https://git.openjdk.org/jdk.git pull/20099/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20099

View PR using the GUI difftool:
$ git pr show -t 20099

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20099.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2024

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 9, 2024

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336012: Fix usages of jtreg-reserved properties

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • e0fb949: 8335779: JFR: Hide sleep events
  • 537d20a: 8335766: Switch case with pattern matching and guard clause compiles inconsistently
  • a44b60c: 8335778: runtime/ClassInitErrors/TestStackOverflowDuringInit.java fails on ppc64 platforms after JDK-8334545
  • b5909ca: 8323242: Remove vestigial DONT_USE_REGISTER_DEFINES
  • dcf4e0d: 8335966: Remove incorrect problem listing of java/lang/instrument/NativeMethodPrefixAgent.java in ProblemList-Virtual.txt
  • 1472124: 8333364: Minor cleanup could be done in com.sun.crypto.provider
  • 7e11fb7: 8335688: Fix -Wzero-as-null-pointer-constant warnings from fflush calls in jvmti tests
  • 531a6d8: 8335911: Document ccls indexer in doc/ide.md
  • 0e0dfca: 8330806: test/hotspot/jtreg/compiler/c1/TestLargeMonitorOffset.java fails on ARM32
  • f3ff4f7: 8335882: platform/cgroup/TestSystemSettings.java fails on Alpine Linux

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8336012: Fix usages of jtreg-reserved properties 8336012: Fix usages of jtreg-reserved properties Jul 9, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 9, 2024
@openjdk
Copy link

openjdk bot commented Jul 9, 2024

@sormuras The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 9, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 9, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 10, 2024
@sormuras
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 10, 2024

Going to push as commit e6c5aa7.
Since your change was applied there have been 10 commits pushed to the master branch:

  • e0fb949: 8335779: JFR: Hide sleep events
  • 537d20a: 8335766: Switch case with pattern matching and guard clause compiles inconsistently
  • a44b60c: 8335778: runtime/ClassInitErrors/TestStackOverflowDuringInit.java fails on ppc64 platforms after JDK-8334545
  • b5909ca: 8323242: Remove vestigial DONT_USE_REGISTER_DEFINES
  • dcf4e0d: 8335966: Remove incorrect problem listing of java/lang/instrument/NativeMethodPrefixAgent.java in ProblemList-Virtual.txt
  • 1472124: 8333364: Minor cleanup could be done in com.sun.crypto.provider
  • 7e11fb7: 8335688: Fix -Wzero-as-null-pointer-constant warnings from fflush calls in jvmti tests
  • 531a6d8: 8335911: Document ccls indexer in doc/ide.md
  • 0e0dfca: 8330806: test/hotspot/jtreg/compiler/c1/TestLargeMonitorOffset.java fails on ARM32
  • f3ff4f7: 8335882: platform/cgroup/TestSystemSettings.java fails on Alpine Linux

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 10, 2024
@openjdk openjdk bot closed this Jul 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 10, 2024
@openjdk
Copy link

openjdk bot commented Jul 10, 2024

@sormuras Pushed as commit e6c5aa7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sormuras sormuras deleted the JDK-8336012-jtreg-reserved-property branch July 10, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants