Skip to content

8337787: Fix -Wzero-as-null-pointer-constant warnings when JVMTI feature is disabled#20455

Closed
kimbarrett wants to merge 1 commit intoopenjdk:masterfrom
kimbarrett:not-jvmti
Closed

8337787: Fix -Wzero-as-null-pointer-constant warnings when JVMTI feature is disabled#20455
kimbarrett wants to merge 1 commit intoopenjdk:masterfrom
kimbarrett:not-jvmti

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Aug 3, 2024

Please review this trivial change that replaces some uses of literal 0 as a
null pointer constant when JVMTI is disabled to instead use nullptr.

Testing: mach5 tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8337787: Fix -Wzero-as-null-pointer-constant warnings when JVMTI feature is disabled (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20455/head:pull/20455
$ git checkout pull/20455

Update a local copy of the PR:
$ git checkout pull/20455
$ git pull https://git.openjdk.org/jdk.git pull/20455/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20455

View PR using the GUI difftool:
$ git pr show -t 20455

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20455.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2024

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 3, 2024

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337787: Fix -Wzero-as-null-pointer-constant warnings when JVMTI feature is disabled

Reviewed-by: ayang, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • fbe8a81: 8333144: docker tests do not work when ubsan is configured
  • dabdae6: 8334599: Improve code from JDK-8302671
  • 8bd3cd5: 8337716: ByteBuffer hashCode implementations are inconsistent

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 3, 2024
@openjdk
Copy link

openjdk bot commented Aug 3, 2024

@kimbarrett The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Aug 3, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 3, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 5, 2024
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@kimbarrett
Copy link
Author

Thanks for reviews @albertnetymk and @sspitsyn

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 5, 2024

Going to push as commit 42652b2.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 807186f: 8337784: Fix simple -Wzero-as-null-pointer-constant warnings in linux/posix code
  • e68df52: 8337054: JDK 23 RDP2 L10n resource files update
  • 9856216: 8336928: GHA: Bundle artifacts removal broken
  • 219e1eb: 8337712: Wrong javadoc in java.util.Date#toString(): "61" and right parenthesis
  • 97afbd9: 8336410: runtime/NMT/TotalMallocMmapDiffTest.java Total malloc diff is incorrect. Expected malloc diff range
  • c095c0e: 8336489: Track scoped accesses in JVMCI compiled code
  • 7e925d7: 8337283: configure.log is truncated when build dir is on different filesystem
  • 2e093b0: 8337779: test/jdk/jdk/jfr/jvm/TestHiddenWait.java is a bit fragile
  • d3e7b0c: 8336462: ConcurrentSkipListSet Javadoc incorrectly warns about size method complexity
  • be34730: 8335257: Refactor code to create Initialized Assertion Predicates into separate class
  • ... and 3 more: https://git.openjdk.org/jdk/compare/367e0a65561f95aad61b40930d5f46843fee3444...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 5, 2024
@openjdk openjdk bot closed this Aug 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 5, 2024
@openjdk
Copy link

openjdk bot commented Aug 5, 2024

@kimbarrett Pushed as commit 42652b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the not-jvmti branch August 5, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants