8338286: GHA: Demote x86_32 to hotspot build only#20563
8338286: GHA: Demote x86_32 to hotspot build only#20563shipilev wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
magicus
left a comment
There was a problem hiding this comment.
This sounds reasonable. The implementation seems correct.
|
Thanks! Any other opinions on this? |
|
By the powers vested in me as x86_32 maintainer I declare this PR integrateable. :) /integrate |
|
Going to push as commit da7311b.
Your commit was automatically rebased without conflicts. |
|
Sad to see a port start to go, but it had to be done, You were good, x86_32 port :) |
As planned in JDK-8338285, we are about to deprecate the port for removal. It makes little sense to continue testing the port, and thus block development and integration of new features.
Ahead of that JEP, we can separately decide to disable the x86_32 test jobs in GHA. This effectively demotes x86_32 to any other port that only builds Hotspot and relies on port maintainers to provide the runtime testing. Building hotspot in both release and debug modes still gives us some level of 32-bit cleanliness checks.
This is deliberately separate change, so that Update Releases could decide to demote their x86_32 jobs as well.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20563/head:pull/20563$ git checkout pull/20563Update a local copy of the PR:
$ git checkout pull/20563$ git pull https://git.openjdk.org/jdk.git pull/20563/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20563View PR using the GUI difftool:
$ git pr show -t 20563Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20563.diff
Webrev
Link to Webrev Comment