Skip to content

8338286: GHA: Demote x86_32 to hotspot build only#20563

Closed
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8338286-disable-x86-32
Closed

8338286: GHA: Demote x86_32 to hotspot build only#20563
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8338286-disable-x86-32

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Aug 13, 2024

As planned in JDK-8338285, we are about to deprecate the port for removal. It makes little sense to continue testing the port, and thus block development and integration of new features.

Ahead of that JEP, we can separately decide to disable the x86_32 test jobs in GHA. This effectively demotes x86_32 to any other port that only builds Hotspot and relies on port maintainers to provide the runtime testing. Building hotspot in both release and debug modes still gives us some level of 32-bit cleanliness checks.

This is deliberately separate change, so that Update Releases could decide to demote their x86_32 jobs as well.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8338286: GHA: Demote x86_32 to hotspot build only (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20563/head:pull/20563
$ git checkout pull/20563

Update a local copy of the PR:
$ git checkout pull/20563
$ git pull https://git.openjdk.org/jdk.git pull/20563/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20563

View PR using the GUI difftool:
$ git pr show -t 20563

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20563.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 13, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338286: GHA: Demote x86_32 to hotspot build only

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • fbe4cc9: 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when failing due to a LinkageError or other errors
  • ba69ed7: 8338202: Shenandoah: Improve handshake closure labels
  • 5bf2709: 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set
  • 73f7a5f: 8338155: Fix -Wzero-as-null-pointer-constant warnings involving PTHREAD_MUTEX_INITIALIZER
  • c27a8c8: 8338124: C2 SuperWord: MulAddS2I input permutation still partially broken after JDK-8333840
  • 73ddb7d: 8335628: C2 SuperWord: cleanup: remove SuperWord::longer_type_for_conversion
  • d77e6fe: 8338154: Fix -Wzero-as-null-pointer-constant warnings in gtest framework
  • e70c9bc: 8338248: PartialArrayStateAllocator::Impl leaks Arena array
  • 5079c38: 8338160: Fix -Wzero-as-null-pointer-constant warnings in management.cpp
  • 4417c27: 8330535: Update nsk/jdb tests to use driver instead of othervm
  • ... and 11 more: https://git.openjdk.org/jdk/compare/03204600c596214895ef86581eba9722f76d39b3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 13, 2024
@openjdk
Copy link

openjdk bot commented Aug 13, 2024

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Aug 13, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 13, 2024

Webrevs

Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds reasonable. The implementation seems correct.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 13, 2024
@gdams
Copy link
Member

gdams commented Aug 14, 2024

This is great to see! thanks for pushing it through @shipilev. I wonder if it's time for me to reboot my PR about testing Alpine Linux if we're dropping back on the actions usage here: #7771

@shipilev
Copy link
Member Author

Thanks! Any other opinions on this?

@shipilev
Copy link
Member Author

By the powers vested in me as x86_32 maintainer I declare this PR integrateable. :)

/integrate

@openjdk
Copy link

openjdk bot commented Aug 15, 2024

Going to push as commit da7311b.
Since your change was applied there have been 50 commits pushed to the master branch:

  • f536f5a: 8336086: G1: Use one G1CardSet instance for all young regions
  • 4c34433: 8338304: clang on Linux - check for lld presence after JDK-8333189
  • 4669e7b: 8337102: JITTester: Fix breaks in static initialization blocks
  • e3a5e26: 8338344: Test TestPrivilegedMode.java intermittent fails java.lang.NoClassDefFoundError: jdk/test/lib/Platform
  • aff7936: 8338333: Add jls links to javax.lang.model.element.Modifier
  • 723ac57: 8332488: Add JVMTI DataDumpRequest to the debug agent
  • c0384b6: 8337237: Use FFM instead of Unsafe for Java 2D RenderBuffer class
  • 6a39014: 8338110: Exclude Fingerprinter::do_type from ubsan checks
  • 0e3903f: 8338393: Parallel: Remove unused ParallelCompactData::clear_range
  • d8e4d3f: 8338402: GHA: some of bundles may not get removed
  • ... and 40 more: https://git.openjdk.org/jdk/compare/03204600c596214895ef86581eba9722f76d39b3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 15, 2024
@openjdk openjdk bot closed this Aug 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 15, 2024
@openjdk
Copy link

openjdk bot commented Aug 15, 2024

@shipilev Pushed as commit da7311b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheShermanTanker
Copy link
Contributor

Sad to see a port start to go, but it had to be done, You were good, x86_32 port :)

@shipilev shipilev deleted the JDK-8338286-disable-x86-32 branch January 8, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants