8339319: ProblemList runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java

[jaikiran]

Can I please get a review of this change which adds a problem listing entry for the runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java test?

This test is failing after changes in https://bugs.openjdk.org/browse/JDK-8338257 if -Xcheck:jni is used for running that test. The underlying issue is known (to David) but will require a few days to be addressed. So we'll problemlist this on all platforms until then.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339319: ProblemList runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java (Sub-task - P3)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)
• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20793/head:pull/20793
$ git checkout pull/20793

Update a local copy of the PR:
$ git checkout pull/20793
$ git pull https://git.openjdk.org/jdk.git pull/20793/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20793

View PR using the GUI difftool:
$ git pr show -t 20793

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20793.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339319: ProblemList runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java

Reviewed-by: dfuchs, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 3a352b8: 8339191: JFR: Bulk read support for ChunkInputStream

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[jaikiran]

/label add hotspot-runtime

[openjdk]

@jaikiran
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (5e51fb3e)

[dfuch]

LGTM

[dcubed-ojdk]

Thumbs up. This is a trivial fix.

[jaikiran]

Thank you Daniel and Dan for the reviews.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 2fb8305.
Since your change was applied there has been 1 commit pushed to the master branch:

• 3a352b8: 8339191: JFR: Bulk read support for ChunkInputStream

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 2fb8305.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.