Skip to content

8341162: Open source some of the AWT window test#21284

Closed
jayathirthrao wants to merge 5 commits intoopenjdk:masterfrom
jayathirthrao:JDK-8341162_open
Closed

8341162: Open source some of the AWT window test#21284
jayathirthrao wants to merge 5 commits intoopenjdk:masterfrom
jayathirthrao:JDK-8341162_open

Conversation

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Oct 1, 2024

Clean up and open source some of the AWT window tests.
Automated test OwnedWindowShowTest.java is verified in our CI also and it passes on all platforms.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8341162: Open source some of the AWT window test (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21284/head:pull/21284
$ git checkout pull/21284

Update a local copy of the PR:
$ git checkout pull/21284
$ git pull https://git.openjdk.org/jdk.git pull/21284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21284

View PR using the GUI difftool:
$ git pr show -t 21284

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21284.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2024

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341162: Open source some of the AWT window test

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 146 new commits pushed to the master branch:

  • 0dd4997: 8340555: Open source DnD tests - Set4
  • beb2a51: 8341377: Update VMProps.isCDSRuntimeOptionsCompatible to include Parallel and Serial GC
  • 42f3255: 8341053: Two CDS tests fail again with -UseCompressedOops and UseSerialGC/UseParallelGC
  • feb6a83: 8340945: Ubsan: oopStorage.cpp:374:8: runtime error: applying non-zero offset 18446744073709551168 to null pointer
  • db61458: 8341298: Open source more AWT window tests
  • 72ac72f: 8341413: Stop including osThread_os.hpp in the middle of the OSThread class
  • 7fa2f22: 8341127: Extra call to MethodHandle::asType from memory segment var handles fails to inline
  • 1bdd79e: 8341261: Tests assume UnlockExperimentalVMOptions is disabled by default
  • ec020f3: 8340426: ZGC: Move defragment out of the allocation path
  • a63ac5a: 8340792: -XX:+PrintInterpreter: instructions should only be printed if printing all InterpreterCodelets
  • ... and 136 more: https://git.openjdk.org/jdk/compare/b1f8d2ea76322a89eea84851a1e791f52c31261b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2024
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@jayathirthrao The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 1, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 4, 2024
@jayathirthrao
Copy link
Member Author

Thanks for the review.
Updated automated test is verified in our CI also.

@jayathirthrao
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 4, 2024

Going to push as commit c8e70df.
Since your change was applied there have been 149 commits pushed to the master branch:

  • 2e5b420: 8340326: Remove references to Applet in core-libs/security tests
  • f5f0852: 8341379: Shenandoah: Improve lock contention during cleanup
  • 04c9c5f: 8341111: open source several AWT tests including menu shortcut tests
  • 0dd4997: 8340555: Open source DnD tests - Set4
  • beb2a51: 8341377: Update VMProps.isCDSRuntimeOptionsCompatible to include Parallel and Serial GC
  • 42f3255: 8341053: Two CDS tests fail again with -UseCompressedOops and UseSerialGC/UseParallelGC
  • feb6a83: 8340945: Ubsan: oopStorage.cpp:374:8: runtime error: applying non-zero offset 18446744073709551168 to null pointer
  • db61458: 8341298: Open source more AWT window tests
  • 72ac72f: 8341413: Stop including osThread_os.hpp in the middle of the OSThread class
  • 7fa2f22: 8341127: Extra call to MethodHandle::asType from memory segment var handles fails to inline
  • ... and 139 more: https://git.openjdk.org/jdk/compare/b1f8d2ea76322a89eea84851a1e791f52c31261b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2024
@openjdk openjdk bot closed this Oct 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 4, 2024
@openjdk
Copy link

openjdk bot commented Oct 4, 2024

@jayathirthrao Pushed as commit c8e70df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants