8342704: GHA: Report truncation is broken after JDK-8341424

[shipilev]

When GH output is too large, we do not actually truncate it after JDK-8341424. The error log would be:

Run bash ./.github/scripts/gen-test-results.sh "$GITHUB_STEP_SUMMARY"
./.github/scripts/gen-test-results.sh: line 28: report-utils.sh: No such file or directory
./.github/scripts/gen-test-results.sh: line 97: truncate_summary: command not found

Error: Process completed with exit code 127.
Error: $GITHUB_STEP_SUMMARY upload aborted, supports content up to a size of 1024k, got 1579k. For more information see: https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#adding-a-markdown-summary

This is because we import report-utils.sh incorrectly: scripts try to find it in current directory, which is not the same directory where the importing scripts are located. And we never see it in normal cases, because scripts are just eating the errors without any other observable effects.

Additional testing:

• GHA checks work with deliberately failing tests

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8342704: GHA: Report truncation is broken after JDK-8341424 (Bug - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Julian Waters (@TheShermanTanker - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21617/head:pull/21617
$ git checkout pull/21617

Update a local copy of the PR:
$ git checkout pull/21617
$ git pull https://git.openjdk.org/jdk.git pull/21617/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21617

View PR using the GUI difftool:
$ git pr show -t 21617

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21617.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342704: GHA: Report truncation is broken after JDK-8341424

Reviewed-by: erikj, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 7133d1b: 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only
• 8276a41: 8342715: x86 unused orw instruction encoding could be removed
• 5a4b180: 8342011: Conditionally compile ReservedHeapSpace compressed heap support
• e0c6480: 8338570: sun/font/HBShaper - mismatch in return type of FFM upcall function description and native invocation
• 7158322: 8340477: Remove JDK1.1 compatible behavior for "EST", "MST", and "HST" time zones
• 97c9212: 8342698: Fix order of @param tags in module java.base
• 51a7ff6: 8335271: Specify the MessageFormat ArgumentIndex Implementation Limit
• 52d752c: 8339507: Test generation tool and gtest for testing APX encoding of extended gpr instructions
• 37aa320: 8342376: More reliable OOM handling in ExceptionDuringDumpAtObjectsInitPhase test
• 18bcbf7: 8341052: SHA-512 implementation using SHA-NI
• ... and 10 more: https://git.openjdk.org/jdk/compare/239d84a82a1e6f4ebbd5c5abb320e39cfd5bc330...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following labels will be automatically applied to this pull request:

• build
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[shipilev]

/label remove core-libs

[openjdk]

@shipilev
The core-libs label was successfully removed.

[mlbridge]

Webrevs

• 00: Full (bea443ec)

[TheShermanTanker]

Looks good and trivial

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit bf92c49.
Since your change was applied there have been 21 commits pushed to the master branch:

• 8bcd492: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option
• 7133d1b: 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only
• 8276a41: 8342715: x86 unused orw instruction encoding could be removed
• 5a4b180: 8342011: Conditionally compile ReservedHeapSpace compressed heap support
• e0c6480: 8338570: sun/font/HBShaper - mismatch in return type of FFM upcall function description and native invocation
• 7158322: 8340477: Remove JDK1.1 compatible behavior for "EST", "MST", and "HST" time zones
• 97c9212: 8342698: Fix order of @param tags in module java.base
• 51a7ff6: 8335271: Specify the MessageFormat ArgumentIndex Implementation Limit
• 52d752c: 8339507: Test generation tool and gtest for testing APX encoding of extended gpr instructions
• 37aa320: 8342376: More reliable OOM handling in ExceptionDuringDumpAtObjectsInitPhase test
• ... and 11 more: https://git.openjdk.org/jdk/compare/239d84a82a1e6f4ebbd5c5abb320e39cfd5bc330...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit bf92c49.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.