8343178: Test BasicTest.java javac compile fails cannot find symbol

[sendaoYan]

Hi all,
The test tools/jpackage/share/jdk/jpackage/tests/BasicTest.java javac compile fails cannot find symbol TKit.assertPathNotEmptyDirectory after JDK-8343101. I think we should use TKit.assertDirectoryNotEmpty instead of TKit.assertPathNotEmptyDirectory.
The change has been verified locally on linux-x64, test-fix only , no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8343178: Test BasicTest.java javac compile fails cannot find symbol (Bug - P3)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Alexey Semenyuk (@alexeysemenyukoracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21750/head:pull/21750
$ git checkout pull/21750

Update a local copy of the PR:
$ git checkout pull/21750
$ git pull https://git.openjdk.org/jdk.git pull/21750/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21750

View PR using the GUI difftool:
$ git pr show -t 21750

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21750.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343178: Test BasicTest.java javac compile fails cannot find symbol

Reviewed-by: jpai, asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 54327bc: 8342962: [s390x] TestOSRLotsOfLocals.java crashes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5dd9f8e0)

[jaikiran]

Hello @sendaoYan,

Hi all, The test tools/jpackage/share/jdk/jpackage/tests/BasicTest.java javac compile fails cannot find symbol TKit.assertPathNotEmptyDirectory after JDK-8343178.

I think you meant https://bugs.openjdk.org/browse/JDK-8343101.

I don't have prior knowledge of this area but the change looks OK and trivial to me and would fix a compilation error in the tests.

@sashamatveev or @alexeysemenyukoracle, do you think this looks OK?

[sendaoYan]

I think you meant https://bugs.openjdk.org/browse/JDK-8343101.

Yes, Sorry for the mistake. The PR description has been updated.

[jaikiran]

Aleksei has approved this change, so you can now go ahead with the integration. Thank you for addressing this compilation failure quickly.

[sendaoYan]

Thanks all for the review.

To make less CI noisy, I will integrate this PR now, don't wait 24h.

/integrate

[openjdk]

Going to push as commit df3473e.
Since your change was applied there has been 1 commit pushed to the master branch:

• 54327bc: 8342962: [s390x] TestOSRLotsOfLocals.java crashes

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit df3473e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.