8339891: Several sun/security/ssl/SSLSessionImpl/* tests override test.java.opts

[SoniaZaldana]

Hi all,

This PR addresses 8339891. With this patch, "test.java.opts" aggregates on options set via jtreg as opposed to overriding them.

Thanks,
Sonia

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339891: Several sun/security/ssl/SSLSessionImpl/* tests override test.java.opts (Sub-task - P4)

Reviewers

• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21959/head:pull/21959
$ git checkout pull/21959

Update a local copy of the PR:
$ git checkout pull/21959
$ git pull https://git.openjdk.org/jdk.git pull/21959/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21959

View PR using the GUI difftool:
$ git pr show -t 21959

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21959.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339891: Several sun/security/ssl/SSLSessionImpl/* tests override test.java.opts

Reviewed-by: lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@SoniaZaldana The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (bdacaceb)
• 01: Full - Incremental (4fc8441c)
• 00: Full (39bd0924)

[bridgekeeper]

@SoniaZaldana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@SoniaZaldana This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[lmesnik]

@SoniaZaldana Unfortunately, I don't track the security component and missed your fix.
Could you please re-opened it so I can approve?
Thank you for fixing the bug and sorry for missing PR.

[SoniaZaldana]

/open

[openjdk]

@SoniaZaldana This pull request is now open

[SoniaZaldana]

/integrate

[openjdk]

Going to push as commit 909cef5.
Since your change was applied there have been 39 commits pushed to the master branch:

• 56a1877: 8348170: Unnecessary Hashtable usage in CSS.styleConstantToCssMap
• 9768f60: 8345249: Apply some conservative cleanups in FileURLConnection
• c5a69b6: 8331723: Serial: Remove the unused parameter of the method SerialHeap::gc_prologue
• 9c55e25: 8347981: RISC-V: Add Zfa zli imm loads
• e20bd01: 8344361: Restore null return for invalid services from legacy providers
• 5a0bdd0: 8346890: AArch64: Type profile counters generate suboptimal code
• 4a375e5: 8344232: [PPC64] secondary_super_cache does not scale well: C1 and interpreter
• 0df9dcb: 8346572: Check is_reserved() before using ReservedSpace instances
• a09f06d: 8348265: RMIConnectionImpl: Remove Subject.callAs on MarshalledObject
• 0395593: 8346751: Internal java compiler error with type annotations in constants expression in constant fields
• ... and 29 more: https://git.openjdk.org/jdk/compare/b720517cb33c2119ec6ed85504bce321de748228...master

Your commit was automatically rebased without conflicts.

[openjdk]

@SoniaZaldana Pushed as commit 909cef5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.