Skip to content

8345346: Shenandoah: Description of ShenandoahGCMode still refers to incremental update mode#22502

Closed
earthling-amzn wants to merge 1 commit intoopenjdk:masterfrom
earthling-amzn:fix-mode-description
Closed

8345346: Shenandoah: Description of ShenandoahGCMode still refers to incremental update mode#22502
earthling-amzn wants to merge 1 commit intoopenjdk:masterfrom
earthling-amzn:fix-mode-description

Conversation

@earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Dec 2, 2024

The incremental update mode has been removed and is no longer supported.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345346: Shenandoah: Description of ShenandoahGCMode still refers to incremental update mode (Task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22502/head:pull/22502
$ git checkout pull/22502

Update a local copy of the PR:
$ git checkout pull/22502
$ git pull https://git.openjdk.org/jdk.git pull/22502/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22502

View PR using the GUI difftool:
$ git pr show -t 22502

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22502.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 2, 2024

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 2, 2024

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345346: Shenandoah: Description of ShenandoahGCMode still refers to incremental update mode

Reviewed-by: ysr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 2, 2024
@openjdk
Copy link

openjdk bot commented Dec 2, 2024

@earthling-amzn The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Dec 2, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 2, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 2, 2024
@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 2, 2024

Going to push as commit 1997e89.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 2, 2024
@openjdk openjdk bot closed this Dec 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 2, 2024
@openjdk
Copy link

openjdk bot commented Dec 2, 2024

@earthling-amzn Pushed as commit 1997e89.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants