8346706: RISC-V: Add available registers to hs_err

[robehn]

Hi please consider.

This adds below to hs_err:

Floating point state:
fcsr=1
Floating point registers:
f0=0xffffffff44a72000 | 1.84467e+19
f1=0xffffffff44a72000 | 1.84467e+19
....
f31=0xffffffff44a72000 | 1.84467e+19

Vector state:
vstart=0x0000000000000000
vl=0x0000000000000020
vtype=0x0000000000000000
vcsr=0x0000000000000000
vlenb=0x0000000000000020
Vector registers:
v0=0x0101010101010101010101010101010101010101010101010101010101010101
....
v31=0x0101010101010101010101010101010101010101010101010101010101010101

To get vector the headers need to include those structures, hence build files hackery.
This means if you compile on a kernel without RVV support the error handler will lack support for it.
We don't care about RVV option as carshing in native may still use vector even if the jit do not.

I'm doubt full about the printing as double for fp regs, maybe that should be removed.

Local testing, running t1 over weekend.

Thanks, Robbin

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8346706: RISC-V: Add available registers to hs_err (Enhancement - P4)

Reviewers

• Hamlin Li (@Hamlin-Li - Reviewer)
• Magnus Ihse Bursie (@magicus - Reviewer) Review applies to 5cb8c776
• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22845/head:pull/22845
$ git checkout pull/22845

Update a local copy of the PR:
$ git checkout pull/22845
$ git pull https://git.openjdk.org/jdk.git pull/22845/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22845

View PR using the GUI difftool:
$ git pr show -t 22845

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22845.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346706: RISC-V: Add available registers to hs_err

Reviewed-by: mli, fyang, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• 33f9be8: 8347083: Incomplete logging in nsk/jvmti/ResourceExhausted/resexhausted00* tests
• 8eddf67: 8346887: DrawFocusRect() may cause an assertion failure
• a46ae70: 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class
• 97dd06c: 8347299: Add annotations to test cases in LicenseTest
• 0a35ebf: 8347297: Skip the RuntimeImageSymbolicLinksTest test on Windows when it is executed outside of the jtreg
• b3e8736: 8347296: WinInstallerUiTest fails in local test runs if the path to test work directory is longer that regular
• 1ade96b: 8347042: Remove an extra parenthesis in macro definition in jfrTraceIdMacros.hpp
• db7fa6a: 8347289: HKDF delayed provider selection failed with non-extractable PRK
• 0a5ef82: 8347162: Update problemlist CR for vmTestbase/nsk/jdi/VMOutOfMemoryException
• ea49537: 8310340: assert(_thread->is_interp_only_mode() || stub_caller) failed: expected a stub-caller
• ... and 36 more: https://git.openjdk.org/jdk/compare/08debd335e9160d20b87e06a2e83ddedd5f473b8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@robehn The following labels will be automatically applied to this pull request:

• build
• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[robehn]

Could @erikj79 or @magicus please look the build changes please, thanks!

[mlbridge]

Webrevs

• 03: Full - Incremental (1139816c)
• 02: Full - Incremental (5cb8c776)
• 01: Full - Incremental (49fe4086)
• 00: Full (64f79ef8)

[Hamlin-Li]

Thanks for adding this, it's helpful!

Some minor comments on riscv code.

[magicus]

Build changes look okay. I did not look at hotspot changes so you'll need two reviewers for that as usual.

[RealFYang]

Seems fine to me. Thanks for the update.

[Hamlin-Li]

Looks good, Thanks!

[robehn]

Thanks!

[robehn]

/integrate

[openjdk]

Going to push as commit 765b9e6.
Since your change was applied there have been 49 commits pushed to the master branch:

• d66737e: 8341097: GHA: Demote Mac x86 jobs to build only
• dff5719: 8347126: gc/stress/TestStressG1Uncommit.java gets OOM-killed
• 82e16ba: 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer
• 33f9be8: 8347083: Incomplete logging in nsk/jvmti/ResourceExhausted/resexhausted00* tests
• 8eddf67: 8346887: DrawFocusRect() may cause an assertion failure
• a46ae70: 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class
• 97dd06c: 8347299: Add annotations to test cases in LicenseTest
• 0a35ebf: 8347297: Skip the RuntimeImageSymbolicLinksTest test on Windows when it is executed outside of the jtreg
• b3e8736: 8347296: WinInstallerUiTest fails in local test runs if the path to test work directory is longer that regular
• 1ade96b: 8347042: Remove an extra parenthesis in macro definition in jfrTraceIdMacros.hpp
• ... and 39 more: https://git.openjdk.org/jdk/compare/08debd335e9160d20b87e06a2e83ddedd5f473b8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robehn Pushed as commit 765b9e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.