8346869: [AIX] Add regression test for handling 4 Byte aligned doubles in structures

[TheRealMDoerr]

JDK-8317545 introduced code for supporting 4 Byte aligned doubles:

jdk/src/java.base/share/classes/jdk/internal/foreign/abi/ppc64/aix/AixPPC64Linker.java

Line 59 in 60e0730

protected void checkStructMember(MemoryLayout member, long offset) {

We should test this case. The new test can serve as an example implementation for handling such structures in Java code such that it works on all platforms including AIX.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8346869: [AIX] Add regression test for handling 4 Byte aligned doubles in structures (Sub-task - P4)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)
• Joachim Kern (@JoKern65 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22889/head:pull/22889
$ git checkout pull/22889

Update a local copy of the PR:
$ git checkout pull/22889
$ git pull https://git.openjdk.org/jdk.git pull/22889/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22889

View PR using the GUI difftool:
$ git pr show -t 22889

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22889.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346869: [AIX] Add regression test for handling 4 Byte aligned doubles in structures

Reviewed-by: mbaesken, jkern

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 135 new commits pushed to the master branch:

• a289bcf: 8306579: Consider building with /Zc:throwingNew
• cede304: 8347482: Remove unused field in ParkEvent
• fa5ff82: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set
• cc19897: 8293123: Fix various include file ordering
• 6e43f48: 8346929: runtime/ClassUnload/DictionaryDependsTest.java fails with "Test failed: should be unloaded"
• c885e59: 8346377: Properly support static builds for Windows
• 0612636: 8347373: HTTP/2 flow control checks may count unprocessed data twice
• 450636a: 8347274: Gatherers.mapConcurrent exhibits undesired behavior under variable delays, interruption, and finishing
• 82e2a79: 8347006: LoadRangeNode floats above array guard in arraycopy intrinsic
• 85ed78c: 8345185: Update jpackage to not include service bindings by default
• ... and 125 more: https://git.openjdk.org/jdk/compare/60e0730a3ba26180d0eb2cd278e389c3e70fec5f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@TheRealMDoerr The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ca9f96c9)

[MBaesken]

looks okay, guess you have to adjust the COPYRIGHT year now to 2025 .

[TheRealMDoerr]

looks okay, guess you have to adjust the COPYRIGHT year now to 2025 .

Only if I make more modifications. No files were changed in 2025. The update script says "No files were changed".
But, thanks for the review!

[JoKern65]

C Code LGTM

[TheRealMDoerr]

Thanks for the reviews!

[TheRealMDoerr]

/integrate

[openjdk]

Going to push as commit 61dc07c.
Since your change was applied there have been 143 commits pushed to the master branch:

• 13e1ea5: 8346038: [REDO] - [C1] LIR Operations with one input should be implemented as LIR_Op1
• 7c883c2: 8347605: Use spec tag to refer to IEEE 754 standard
• 4e0ffda: 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk
• e0f2f4b: 8313396: Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION
• b0c131e: 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025
• a7915bb: 8346468: SM cleanup of common test library
• f67b703: 8347427: JTabbedPane/8134116/Bug8134116.java has no license header
• 062f2dc: 8347554: [BACKOUT] C2: implement optimization for series of Add of unique value
• a289bcf: 8306579: Consider building with /Zc:throwingNew
• cede304: 8347482: Remove unused field in ParkEvent
• ... and 133 more: https://git.openjdk.org/jdk/compare/60e0730a3ba26180d0eb2cd278e389c3e70fec5f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit 61dc07c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.