-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8347122: Add missing @serial tags to module java.desktop #22979
Conversation
👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into |
@hns This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 30 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did check that even without these tags, the comments appear in the serialisation spec, so this is really just a source clean up.
/integrate |
Going to push as commit b335ea9.
Your commit was automatically rebased without conflicts. |
Please review a doc-only change to add missing
@serial
javadoc tags in modulejava.desktop
. This is a sub-task of JDK-8286931 to allow us to re-enable the javadoc-serialwarn
option in the JDK doc build, which has been disabled since JDK 19.For private and package-private serialized fields that already have a doc comment, the main description is converted to a block tag by prepending
@serial
since these fields do not require a main description. For protected and public serialized fields that require a main description, an empty@serial
block tag is appended to the doc comment instead. The effect is the same, as the main description is used inserial-form.html
if the@serial
tag is missing or empty. For those fields that do not have a doc comment, a doc comment with an empty@serial
tag is added.This change has no effect on the generated documentation (apart from muting the warnings for missing
@serial
tags when building documentation with-serialwarn
enabled).Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22979/head:pull/22979
$ git checkout pull/22979
Update a local copy of the PR:
$ git checkout pull/22979
$ git pull https://git.openjdk.org/jdk.git pull/22979/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22979
View PR using the GUI difftool:
$ git pr show -t 22979
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22979.diff
Using Webrev
Link to Webrev Comment