-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8347379: Problem list failed tests after JDK-8321413 #23021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back henryjen! A progress list of the required criteria for merging this PR into |
|
@slowhog This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@slowhog To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
dholmes-ora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for addressing this.
|
/integrate |
Problem list two failed tests.
The failure seems to be related to jdk.jlink module not allowed with JEP 493, need more investigation.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23021/head:pull/23021$ git checkout pull/23021Update a local copy of the PR:
$ git checkout pull/23021$ git pull https://git.openjdk.org/jdk.git pull/23021/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23021View PR using the GUI difftool:
$ git pr show -t 23021Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23021.diff