Skip to content

Conversation

@slowhog
Copy link
Contributor

@slowhog slowhog commented Jan 10, 2025

Problem list two failed tests.
The failure seems to be related to jdk.jlink module not allowed with JEP 493, need more investigation.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347379: Problem list failed tests after JDK-8321413 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23021/head:pull/23021
$ git checkout pull/23021

Update a local copy of the PR:
$ git checkout pull/23021
$ git pull https://git.openjdk.org/jdk.git pull/23021/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23021

View PR using the GUI difftool:
$ git pr show -t 23021

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23021.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2025

👋 Welcome back henryjen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@slowhog This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347379: Problem list failed tests after JDK-8321413

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • a9351df: 8346787: Fix two C2 IR matching tests for RISC-V

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 10, 2025
@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@slowhog To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for addressing this.

@slowhog
Copy link
Contributor Author

slowhog commented Jan 10, 2025

/integrate

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 10, 2025
@openjdk
Copy link

openjdk bot commented Jan 10, 2025

Going to push as commit 0210a63.
Since your change was applied there has been 1 commit pushed to the master branch:

  • a9351df: 8346787: Fix two C2 IR matching tests for RISC-V

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2025
@openjdk openjdk bot closed this Jan 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2025
@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@slowhog Pushed as commit 0210a63.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@slowhog slowhog deleted the JDK-8347379 branch January 16, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants