Skip to content

8347922: Remove runtime/cds/appcds/customLoader/HelloCustom_JFR.java from ProblemList.txt#23158

Closed
mgronlun wants to merge 2 commits intoopenjdk:masterfrom
mgronlun:8347922
Closed

8347922: Remove runtime/cds/appcds/customLoader/HelloCustom_JFR.java from ProblemList.txt#23158
mgronlun wants to merge 2 commits intoopenjdk:masterfrom
mgronlun:8347922

Conversation

@mgronlun
Copy link
Copy Markdown

@mgronlun mgronlun commented Jan 16, 2025

Greetings,

Removing the HelloCustom_JFR.java test exclusion from ProblemList.txt.

Testing: Repeated testing of HelloCustom_JFR.java with and without -XX:+UseZGC.

Thanks
Markus


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347922: Remove runtime/cds/appcds/customLoader/HelloCustom_JFR.java from ProblemList.txt (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23158/head:pull/23158
$ git checkout pull/23158

Update a local copy of the PR:
$ git checkout pull/23158
$ git pull https://git.openjdk.org/jdk.git pull/23158/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23158

View PR using the GUI difftool:
$ git pr show -t 23158

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23158.diff

Using Webrev

Link to Webrev Comment

@mgronlun
Copy link
Copy Markdown
Author

/label add hotspot-jfr

@mgronlun
Copy link
Copy Markdown
Author

/label remove hotspot-runtime

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Jan 16, 2025

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Jan 16, 2025

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347922: Remove runtime/cds/appcds/customLoader/HelloCustom_JFR.java from ProblemList.txt

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-jfr hotspot-jfr-dev@openjdk.org labels Jan 16, 2025
@openjdk
Copy link
Copy Markdown

openjdk bot commented Jan 16, 2025

@mgronlun
The hotspot-jfr label was successfully added.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Jan 16, 2025

@mgronlun The hotspot-runtime label was not set.

@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Jan 16, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels Jan 16, 2025
@mgronlun mgronlun changed the title 8347922: Remove runtime/cds/appcds/customLoader/HelloCustom_JFR.java from ProblemList.txt and TEST.groups 8347922: Remove runtime/cds/appcds/customLoader/HelloCustom_JFR.java from ProblemList.txt Jan 17, 2025
@mgronlun mgronlun requested a review from egahlin January 17, 2025 17:42
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 17, 2025
@mgronlun
Copy link
Copy Markdown
Author

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Jan 20, 2025

Going to push as commit 4b4b1e9.
Since your change was applied there have been 36 commits pushed to the master branch:

  • e7a1c86: 8217914: java/net/httpclient/ConnectTimeoutHandshakeSync.java failed on connection refused while doing POST
  • 644d154: 8347474: Options singleton is used before options are parsed
  • 3804082: 8346123: [REDO] NMT should not use ThreadCritical
  • 1f0efc0: 8347343: RISC-V: Unchecked zicntr csr reads
  • ca8ba5c: 8347366: RISC-V: Add extension asserts for CMO instructions
  • 0ff6700: 8347987: Bad ifdef in 8330851
  • e1cf351: 8348013: [doc] fix typo in java.md caused by JDK-8347763
  • 6ef860c: 8332857: Test vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription.java failed
  • 17e3df6: 8347763: [doc] Add documentation of module options for JEP 483
  • 6cc1c0a: 8347422: Crash during safepoint handler execution with -XX:+UseAPX
  • ... and 26 more: https://git.openjdk.org/jdk/compare/764d70b7df18e288582e616c62b0d7078f1ff3aa...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 20, 2025
@openjdk openjdk bot closed this Jan 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 20, 2025
@openjdk
Copy link
Copy Markdown

openjdk bot commented Jan 20, 2025

@mgronlun Pushed as commit 4b4b1e9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants