Skip to content

Conversation

@stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented Jan 21, 2025


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23220/head:pull/23220
$ git checkout pull/23220

Update a local copy of the PR:
$ git checkout pull/23220
$ git pull https://git.openjdk.org/jdk.git pull/23220/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23220

View PR using the GUI difftool:
$ git pr show -t 23220

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23220.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 21, 2025

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jan 21, 2025

@stuart-marks The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 21, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2025

@stuart-marks This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

…spec.

Augment class spec to discuss buffering of bytes from System.in. Change
"terminates the line" with "writes a line separator".
@stuart-marks
Copy link
Member Author

The changes here have been merged into #24438. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants