8348890: Fix docs for -XX:AOT* options in java man page#23343
8348890: Fix docs for -XX:AOT* options in java man page#23343iklam wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
/label hotspot-runtime |
|
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
|
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 42 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@iklam |
Webrevs
|
| storing artifacts produced by AOT optimizations. The AOTCache currently contains | ||
| Java classes and heap objects. The plans is to include other types of artifacts, | ||
| such as execution profiles and compiled methods, in future JDK releases. | ||
| The Ahead-of-Time Cache (AOT Cache) is a container introduced in JDK 24 for |
| artifacts, such as execution profiles and compiled methods. | ||
|
|
||
| An AOTCache is specific to a combination of the following: | ||
| An AOT cache is specific to a combination of the following: |
There was a problem hiding this comment.
of the following
+application configuration options/data/states/conditions:
(Or something specific like that.)
There was a problem hiding this comment.
Actually the AOT cache is more permissive with changes in command-line arguments. However, the three items below are absolute requirements that must be met. That's why I discuss the command-line option compatibility in the "loading of an AOT cache can fail for a number of reasons ..." section below. See the rendered text in https://github.com/iklam/jdk/blob/8348890-fix-xx-aot-docs-in-man-page/src/java.base/share/man/java.md#ahead-of-time-cache
| - A particular OS and CPU architecture. | ||
|
|
||
| If any of the above changes, you must recreate the AOTCache. | ||
| If any of the above changes, you must recreate the AOT cache. |
There was a problem hiding this comment.
Maybe add "The main class may be changed."
There was a problem hiding this comment.
You can change the main class or parameters to the application and will still be able to use the cache, although if you execute new code that was cover during the training run then you will have less benefit from the cache.
|
Thanks @rose00 for the review |
|
Going to push as commit cdc84ac.
Your commit was automatically rebased without conflicts. |
Some problems in the
-XX:AOT*docs are found after JDK-8348515 was integrated. See @rose00 comments in #23287AOTClassLinkingis incorrectRendered text:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23343/head:pull/23343$ git checkout pull/23343Update a local copy of the PR:
$ git checkout pull/23343$ git pull https://git.openjdk.org/jdk.git pull/23343/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23343View PR using the GUI difftool:
$ git pr show -t 23343Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23343.diff
Using Webrev
Link to Webrev Comment