Skip to content

8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test#23542

Closed
myankelev wants to merge 6 commits intoopenjdk:masterfrom
myankelev:JDK-8349534
Closed

8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test#23542
myankelev wants to merge 6 commits intoopenjdk:masterfrom
myankelev:JDK-8349534

Conversation

@myankelev
Copy link
Copy Markdown
Member

@myankelev myankelev commented Feb 10, 2025

Refactored the runNameEquals.sh to java test


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test (Sub-task - P4)

Reviewers

Contributors

  • Weijun Wang <weijun@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23542/head:pull/23542
$ git checkout pull/23542

Update a local copy of the PR:
$ git checkout pull/23542
$ git pull https://git.openjdk.org/jdk.git pull/23542/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23542

View PR using the GUI difftool:
$ git pr show -t 23542

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23542.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Feb 10, 2025

👋 Welcome back myankelev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Feb 10, 2025

@myankelev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test

Co-authored-by: Weijun Wang <weijun@openjdk.org>
Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 106 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 10, 2025
@openjdk
Copy link
Copy Markdown

openjdk bot commented Feb 10, 2025

@myankelev The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Feb 10, 2025
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Feb 10, 2025

Webrevs

Comment thread test/jdk/sun/security/krb5/Krb5NameEquals.java Outdated
Comment thread test/jdk/sun/security/krb5/Krb5NameEquals.java Outdated
Comment thread test/jdk/sun/security/krb5/Krb5NameEquals.java Outdated
Comment thread test/jdk/sun/security/krb5/Krb5NameEquals.java Outdated
Comment thread test/jdk/sun/security/krb5/Krb5NameEquals.java Outdated
Comment thread test/jdk/sun/security/krb5/Krb5NameEquals.java Outdated
Comment thread test/jdk/sun/security/krb5/Krb5NameEquals.java Outdated
@myankelev
Copy link
Copy Markdown
Member Author

Idea to check the availability of kerberos & code is done by @wangweij

@myankelev
Copy link
Copy Markdown
Member Author

/author set @wangweij

@openjdk
Copy link
Copy Markdown

openjdk bot commented Feb 11, 2025

@myankelev Only Committers are allowed to issue the author command.

@myankelev
Copy link
Copy Markdown
Member Author

/contributor add @wangweij

@openjdk
Copy link
Copy Markdown

openjdk bot commented Feb 11, 2025

@myankelev
Contributor Weijun Wang <weijun@openjdk.org> successfully added.

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 11, 2025

@myankelev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@myankelev
Copy link
Copy Markdown
Member Author

Still needs an approval

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 8, 2025

@myankelev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@myankelev
Copy link
Copy Markdown
Member Author

Still needs a review

@mcpowers
Copy link
Copy Markdown
Contributor

mcpowers commented Apr 9, 2025

Looks good to me. IntelliJ couldn't find problems either.

Comment thread test/jdk/sun/security/krb5/Krb5NameEquals.java
Copy link
Copy Markdown
Member

@seanjmullan seanjmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug needs a noreg-self label; otherwise looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 10, 2025
@myankelev
Copy link
Copy Markdown
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 10, 2025
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 10, 2025

@myankelev
Your change (at version f3e3c55) is now ready to be sponsored by a Committer.

@seanjmullan
Copy link
Copy Markdown
Member

/sponsor

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 10, 2025

Going to push as commit 0e223f1.
Since your change was applied there have been 106 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 10, 2025
@openjdk openjdk bot closed this Apr 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 10, 2025
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 10, 2025

@seanjmullan @myankelev Pushed as commit 0e223f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

5 participants