8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test#23542
8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test#23542myankelev wants to merge 6 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back myankelev! A progress list of the required criteria for merging this PR into |
|
@myankelev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 106 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@myankelev The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
Idea to check the availability of kerberos & code is done by @wangweij |
|
/author set @wangweij |
|
@myankelev Only Committers are allowed to issue the |
|
/contributor add @wangweij |
|
@myankelev |
|
@myankelev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Still needs an approval |
|
@myankelev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Still needs a review |
|
Looks good to me. IntelliJ couldn't find problems either. |
seanjmullan
left a comment
There was a problem hiding this comment.
Bug needs a noreg-self label; otherwise looks good.
|
/integrate |
|
@myankelev |
|
/sponsor |
|
Going to push as commit 0e223f1.
Your commit was automatically rebased without conflicts. |
|
@seanjmullan @myankelev Pushed as commit 0e223f1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Refactored the runNameEquals.sh to java test
Progress
Issue
Reviewers
Contributors
<weijun@openjdk.org>Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23542/head:pull/23542$ git checkout pull/23542Update a local copy of the PR:
$ git checkout pull/23542$ git pull https://git.openjdk.org/jdk.git pull/23542/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23542View PR using the GUI difftool:
$ git pr show -t 23542Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23542.diff
Using Webrev
Link to Webrev Comment