Skip to content

8350643: G1: Make loop iteration variable type correspond to limit in G1SurvRateGroup #23773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tschatzl wants to merge 2 commits into from
Closed

8350643: G1: Make loop iteration variable type correspond to limit in G1SurvRateGroup #23773

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51347fc
8350643
tschatzl Feb 25, 2025
9cf3489
Merge branch 'master' into 8350643-loop-counter-variable-type
tschatzl Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/hotspot/share/gc/g1/g1SurvRateGroup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ void G1SurvRateGroup::reset() {
// The call to stop_adding_regions() will use "new" to refill
// the _surv_rate_pred array, so we need to make sure to call
// "delete".
for (size_t i = 0; i < _stats_arrays_length; ++i) {
for (uint i = 0; i < _stats_arrays_length; ++i) {
delete _surv_rate_predictors[i];
}
_stats_arrays_length = 0;
Expand Down Expand Up @@ -76,7 +76,7 @@ void G1SurvRateGroup::stop_adding_regions() {
? _accum_surv_rate_pred[_stats_arrays_length - 1] - _accum_surv_rate_pred[_stats_arrays_length - 2]
: InitialSurvivorRate;

for (size_t i = _stats_arrays_length; i < _num_added_regions; ++i) {
for (uint i = _stats_arrays_length; i < _num_added_regions; ++i) {
// Initialize predictors and accumulated survivor rate predictions.
_surv_rate_predictors[i] = new TruncatedSeq(10);
if (i == 0) {
Expand Down Expand Up @@ -123,7 +123,7 @@ double G1SurvRateGroup::accum_surv_rate_pred(uint age) const {
void G1SurvRateGroup::fill_in_last_surv_rates() {
if (_num_added_regions > 0) { // conservative
double surv_rate = _surv_rate_predictors[_num_added_regions-1]->last();
for (size_t i = _num_added_regions; i < _stats_arrays_length; ++i) {
for (uint i = _num_added_regions; i < _stats_arrays_length; ++i) {
_surv_rate_predictors[i]->add(surv_rate);
}
}
Expand All @@ -132,7 +132,7 @@ void G1SurvRateGroup::fill_in_last_surv_rates() {
void G1SurvRateGroup::finalize_predictions(const G1Predictions& predictor) {
double accum = 0.0;
double pred = 0.0;
for (size_t i = 0; i < _stats_arrays_length; ++i) {
for (uint i = 0; i < _stats_arrays_length; ++i) {
pred = predictor.predict_in_unit_interval(_surv_rate_predictors[i]);
accum += pred;
_accum_surv_rate_pred[i] = accum;
Expand Down