Skip to content

Conversation

@hns
Copy link
Member

@hns hns commented Mar 13, 2025

Patch to strip newline character at the beginning of <pre><code>. Work in progress / proof of concept.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24038/head:pull/24038
$ git checkout pull/24038

Update a local copy of the PR:
$ git checkout pull/24038
$ git pull https://git.openjdk.org/jdk.git pull/24038/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24038

View PR using the GUI difftool:
$ git pr show -t 24038

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24038.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2025

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Mar 13, 2025

@hns The following labels will be automatically applied to this pull request:

  • compiler
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org compiler compiler-dev@openjdk.org labels Mar 13, 2025
@hns
Copy link
Member Author

hns commented Mar 19, 2025

Closing as this PR as the change depends on #24032

@hns hns closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org javadoc javadoc-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant