8320997: RISC-V: C2 ReverseV

[Hamlin-Li]

Hi,

Can you help to review this patch to implement ReverseV?

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8320997: RISC-V: C2 ReverseV (Sub-task - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Ludovic Henry (@luhenry - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24096/head:pull/24096
$ git checkout pull/24096

Update a local copy of the PR:
$ git checkout pull/24096
$ git pull https://git.openjdk.org/jdk.git pull/24096/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24096

View PR using the GUI difftool:
$ git pr show -t 24096

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24096.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320997: RISC-V: C2 ReverseV

Reviewed-by: fyang, luhenry

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• b32be18: 8352178: Add precondition in VMThread::execute to prevent deadlock
• 07667ca: 8352506: Simplify make/test/JtregNativeHotspot.gmk
• b545b9e: 8352584: [Backout] G1: Pinned regions with pinned objects only reachable by native code crash VM
• 1c0fa0a: 8352512: TestVectorZeroCount: counter not reset between iterations
• 466f82a: 8314999: IR framework fails to detect allocation
• 06ba6cf: 8329173: LCMS_CFLAGS from configure are lost
• 56038fb: 8352317: Assertion failure during size estimation of BoxLockNode with -XX:+UseAPX
• 2bc4f64: 8335708: C2: Compile::verify_graph_edges must start at root and safepoints, just like CCP traversal
• 9a17a6f: 8350749: Upgrade JLine to 3.29.0
• 91836e1: 8352276: Skip jtreg tests using native executable with libjvm.so/libjli.so dependencies on static JDK
• ... and 31 more: https://git.openjdk.org/jdk/compare/e1bcff3ada9214940e9c71ba4ed5ba93d0218af2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cb5e0fbc)

[RealFYang]

That looks great to me. Thanks!

[Hamlin-Li]

That looks great to me. Thanks!

Thank you!

[Hamlin-Li]

Thank you @luhenry !

[Hamlin-Li]

/integrate

[openjdk]

Going to push as commit 9f582e5.
Since your change was applied there have been 84 commits pushed to the master branch:

• 6879c44: 8351405: G1: Collection set early pruning causes suboptimal region selection
• aee4d69: 8348829: Remove ObjectMonitor perf counters
• f9bcef4: 8351627: C2 AArch64 ROR/ROL: assert((1 << ((T>>1)+3)) > shift) failed: Invalid Shift value
• 17dc30c: 8352414: JFR: JavaMonitorDeflateEvent crashes when deflated monitor object is dead
• 6bc4803: 8351277: Remove pipewire from AIX build
• c94bc74: 8352595: Regression of JDK-8314999 in IR matching
• 48fac66: 8347406: [REDO] C1/C2 don't handle allocation failure properly during initialization (RuntimeStub::new_runtime_stub fatal crash)
• 99c8a6e: 8350463: AArch64: Add vector rearrange support for small lane count vectors
• b2da0d3: 8352289: [macos] Review skipped tests in tools/jpackage/macosx/SigningPackage*
• ba658a7: 8349522: AArch64: Add backend implementation for new unsigned and saturating vector operations
• ... and 74 more: https://git.openjdk.org/jdk/compare/e1bcff3ada9214940e9c71ba4ed5ba93d0218af2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit 9f582e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.