8352579: Refactor CDS legacy optimization for lambda proxy classes

[iklam]

Since JDK 16, CDS has provided limited optimization for lambda expressions. This has been superseded by JEP 483 and is useful only when -XX:+AOTClassLinking is not enabled (which is the case for the default CDS archive, for compatibility reasons).

The "legacy lambda optimization" may eventually be removed. For the time being, we should consolidate the code into a single source code and clearly mark its uses. This way we can avoid confusion with the JEP 483 code for supporting lambdas (and other java.lang.invoke functionalities).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352579: Refactor CDS legacy optimization for lambda proxy classes (Enhancement - P4)

Reviewers

• Matias Saavedra Silva (@matias9927 - Reviewer) Review applies to bd642f8e
• Calvin Cheung (@calvinccheung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24145/head:pull/24145
$ git checkout pull/24145

Update a local copy of the PR:
$ git checkout pull/24145
$ git pull https://git.openjdk.org/jdk.git pull/24145/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24145

View PR using the GUI difftool:
$ git pr show -t 24145

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24145.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352579: Refactor CDS legacy optimization for lambda proxy classes

Reviewed-by: ccheung, matsaave

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (1c34d836)
• 03: Full - Incremental (bd642f8e)
• 02: Full - Incremental (87b34cee)
• 01: Full - Incremental (c8cfc851)
• 00: Full (06648904)

[matias9927]

Thanks for addressing our offline conversation, looks good to me!

[calvinccheung]

Spotted couple of extra include statements. Looks good.

[calvinccheung]

Extra include at line 31?

[iklam]

jfrEvents.hpp is needed by EventClassLoad on line 360

[calvinccheung]

Pre-existing: I think the include of cds/archiveHeapLoader.hpp at line #27 is unnecessary.

[iklam]

Removed.

[calvinccheung]

Looks good.

[iklam]

Thanks @matias9927 and @calvinccheung for the review
/integrate

[openjdk]

Going to push as commit 2483340.

[openjdk]

@iklam Pushed as commit 2483340.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.