8350705: [JMH] test security.SSLHandshake failed for 2 threads configuration

[djelinski]

Update the SSLHandshake benchmark to enable running in multiple threads.

This PR changes the scope of the state from per-benchmark to per-thread. The server SSLContext is still shared across all threads to simulate the scenario where multiple clients try to connect to the same server at the same time.

Before the change, running this benchmark with make test TEST=micro:SSLHandshake MICRO=OPTIONS="-t 3" failed with an exception. After this change the benchmark completes successfully.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350705: [JMH] test security.SSLHandshake failed for 2 threads configuration (Enhancement - P4)

Reviewers

• Hai-May Chao (@haimaychao - Committer)
• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24195/head:pull/24195
$ git checkout pull/24195

Update a local copy of the PR:
$ git checkout pull/24195
$ git pull https://git.openjdk.org/jdk.git pull/24195/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24195

View PR using the GUI difftool:
$ git pr show -t 24195

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24195.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350705: [JMH] test security.SSLHandshake failed for 2 threads configuration

Reviewed-by: hchao, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 267 new commits pushed to the master branch:

• 676cfae: 8354016: Update ReentrantReadWriteLock documentation to reflect its new max capacity
• 250437e: 8351654: Agent transformer bytecodes should be verified
• d9f2e69: 8352963: [REDO] Missing late inline cleanup causes compiler/vectorapi/VectorLogicalOpIdentityTest.java IR failure
• ... and 264 more: https://git.openjdk.org/jdk/compare/e23e0f85ef0f959a68adda0cff9e721ba2173ffc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@djelinski The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ee66fac3)

[haimaychao]

Changes look good.

[djelinski]

Thanks @haimaychao for the review!

Can I get a second review please?

[seanjmullan]

Looks good. The bug needs a noreg label.

[djelinski]

Thanks for the reviews! Label added.

/integrate

[openjdk]

Going to push as commit 58ff36f.
Since your change was applied there have been 267 commits pushed to the master branch:

• 676cfae: 8354016: Update ReentrantReadWriteLock documentation to reflect its new max capacity
• 250437e: 8351654: Agent transformer bytecodes should be verified
• d9f2e69: 8352963: [REDO] Missing late inline cleanup causes compiler/vectorapi/VectorLogicalOpIdentityTest.java IR failure
• ... and 264 more: https://git.openjdk.org/jdk/compare/e23e0f85ef0f959a68adda0cff9e721ba2173ffc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@djelinski Pushed as commit 58ff36f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.