Skip to content

Conversation

@koushikthirupattur
Copy link
Contributor

@koushikthirupattur koushikthirupattur commented Mar 24, 2025

This option dumped the permissions that the SecureClassLoader assigns to ProtectionDomains, but with the disabling of the Security Manager in JDK 24, these permissions are always empty and the debugging has no value. So this option should be removed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8352902 to be approved
  • Commit message must refer to an issue

Issues

  • JDK-8351366: Remove the java.security.debug=scl option (Bug - P4)
  • JDK-8352902: Remove the java.security.debug=scl option (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24208/head:pull/24208
$ git checkout pull/24208

Update a local copy of the PR:
$ git checkout pull/24208
$ git pull https://git.openjdk.org/jdk.git pull/24208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24208

View PR using the GUI difftool:
$ git pr show -t 24208

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24208.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2025

👋 Welcome back koushikthirupattur! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

@koushikthirupattur This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351366: Remove the java.security.debug=scl option

Reviewed-by: hchao, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 259 new commits pushed to the master branch:

  • 4247744: 8351435: Change the default Console implementation back to the built-in one in java.base module
  • 9c06dcb: 8349583: Add mechanism to disable signature schemes based on their TLS scope
  • cd5a43a: 8353126: Open source events tests batch1
  • e4e6278: 8346129: Simplify EdDSA & XDH curve name usage
  • 7a2e198: 8352277: java.security documentation: incorrect regex syntax describing "usage" algorithm constraint
  • b7ca76e: 8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException
  • bbd5b17: 8339280: jarsigner -verify performs cross-checking between CEN and LOC
  • d4d1835: 8352860: Open source events tests batch0
  • c9c3c15: 8330598: java/net/httpclient/Http1ChunkedTest.java fails with java.util.MissingFormatArgumentException: Format specifier '%s'
  • 804a8fa: 8352765: G1CollectedHeap::expand_and_allocate() may fail to allocate even after heap expansion succeeds
  • ... and 249 more: https://git.openjdk.org/jdk/compare/1dd9cf1018f33af34f1f822cb0d1dc706353bbdf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@haimaychao, @seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

@koushikthirupattur The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Mar 24, 2025
@koushikthirupattur koushikthirupattur marked this pull request as ready for review March 25, 2025 17:12
@openjdk openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels Mar 25, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2025

Webrevs

Copy link
Contributor

@haimaychao haimaychao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: copyright year update in both files.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Mar 27, 2025
@openjdk
Copy link

openjdk bot commented Mar 31, 2025

⚠️ @koushikthirupattur the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8351366
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 31, 2025
@koushikthirupattur
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 31, 2025
@openjdk
Copy link

openjdk bot commented Mar 31, 2025

@koushikthirupattur
Your change (at version 7367139) is now ready to be sponsored by a Committer.

@seanjmullan
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

Going to push as commit 3e96f5c.
Since your change was applied there have been 259 commits pushed to the master branch:

  • 4247744: 8351435: Change the default Console implementation back to the built-in one in java.base module
  • 9c06dcb: 8349583: Add mechanism to disable signature schemes based on their TLS scope
  • cd5a43a: 8353126: Open source events tests batch1
  • e4e6278: 8346129: Simplify EdDSA & XDH curve name usage
  • 7a2e198: 8352277: java.security documentation: incorrect regex syntax describing "usage" algorithm constraint
  • b7ca76e: 8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException
  • bbd5b17: 8339280: jarsigner -verify performs cross-checking between CEN and LOC
  • d4d1835: 8352860: Open source events tests batch0
  • c9c3c15: 8330598: java/net/httpclient/Http1ChunkedTest.java fails with java.util.MissingFormatArgumentException: Format specifier '%s'
  • 804a8fa: 8352765: G1CollectedHeap::expand_and_allocate() may fail to allocate even after heap expansion succeeds
  • ... and 249 more: https://git.openjdk.org/jdk/compare/1dd9cf1018f33af34f1f822cb0d1dc706353bbdf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 31, 2025
@openjdk openjdk bot closed this Mar 31, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 31, 2025
@openjdk
Copy link

openjdk bot commented Mar 31, 2025

@seanjmullan @koushikthirupattur Pushed as commit 3e96f5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants