8352731: Compiler workaround to forcibly set "-Xlint:-options" can be removed

[archiecobbs]

Back in 2011, in order to prevent repeated warnings about bootclasspath not being set (JDK-7022337), code was added to JavaCompiler.java to forcibly set the -Xlint:-options flag after compiler startup:

        // forcibly set the equivalent of -Xlint:-options, so that no further
        // warnings about command line options are generated from this point on
        options.put(XLINT_CUSTOM.primaryName + "-" + LintCategory.OPTIONS.option, "true");
        options.remove(XLINT_CUSTOM.primaryName + LintCategory.OPTIONS.option);

This workaround complicates logic relating to warnings in the "options" category and, due to improvements to the compiler design since then, it's no longer needed to actually fix the problem. So it can be removed.

As a separate cleanup, the field optionsCheckingInitiallyDisabled in JavaCompiler.java is no longer used and so it can also be removed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352731: Compiler workaround to forcibly set "-Xlint:-options" can be removed (Bug - P5)

Reviewers

• Maurizio Cimadamore (@mcimadamore - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24309/head:pull/24309
$ git checkout pull/24309

Update a local copy of the PR:
$ git checkout pull/24309
$ git pull https://git.openjdk.org/jdk.git pull/24309/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24309

View PR using the GUI difftool:
$ git pr show -t 24309

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24309.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352731: Compiler workaround to forcibly set "-Xlint:-options" can be removed

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 787 new commits pushed to the master branch:

• 2ba80d2: 8353586: Open source several toolkit tests
• e50af6d: 8354090: Refactor import warning suppression in Check.java
• c4c3edf: 8341402: BigDecimal's square root optimization
• ... and 784 more: https://git.openjdk.org/jdk/compare/ba28119642a7cfa850707a01ce8e589c3a80d416...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@archiecobbs The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (99b3c35e)

[archiecobbs]

Thanks for the review!

[archiecobbs]

/integrate

[openjdk]

Going to push as commit e604bb9.
Since your change was applied there have been 815 commits pushed to the master branch:

• 2321722: 8346109: Create JDK taglet for additional preview notes
• 9ead2b7: 8354180: Clean up uses of ObjectMonitor caches
• cae7a20: 8353662: Add test for non-local file URL fallback to FTP
• ... and 812 more: https://git.openjdk.org/jdk/compare/ba28119642a7cfa850707a01ce8e589c3a80d416...master

Your commit was automatically rebased without conflicts.

[openjdk]

@archiecobbs Pushed as commit e604bb9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.