8353227: JFR: Prepare tests for strong parser validation

[mgronlun]

Greetings,

Tests:

• jdk/jfr/jvm/TestDumpOnCrash.java
• jdk/jfr/event/runtime/TestShutdownEvent.java

Cannot run with -esa in combination with JDK-8351698, because parser invariants are not guaranteed for emergency dumps, which are provided on a best-effort basis only.

Testing: jdk_jfr

Thanks
Markus

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353227: JFR: Prepare tests for strong parser validation (Bug - P4)

Reviewers

• Erik Gahlin (@egahlin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24317/head:pull/24317
$ git checkout pull/24317

Update a local copy of the PR:
$ git checkout pull/24317
$ git pull https://git.openjdk.org/jdk.git pull/24317/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24317

View PR using the GUI difftool:
$ git pr show -t 24317

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24317.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353227: JFR: Prepare tests for strong parser validation

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• 564066d: 8353118: Deprecate the use of java.locale.useOldISOCodes system property
• a1ab1d8: 8353449: [BACKOUT] One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683
• 2a31f69: 8353331: Test ForkJoinPool20Test::testFixedDelaySequence is failing
• 1809138: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files
• cef5610: 8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683
• 6801eb8: 8352709: Remove bad timing annotations from WhileOpTest.java
• 85a0baf: 8352719: Add an equals sign to the modules statement
• f25f701: 8353226: JFR: emit old object samples must be transitive closure complete for segment
• aff5aa7: 8350566: NMT: add size parameter to MemTracker::record_virtual_memory_tag
• 196334f: 8352046: Test testEcoFriendly() in jdk tools launcher ExecutionEnvironment.java for AIX and Linux/musl is brittle
• ... and 31 more: https://git.openjdk.org/jdk/compare/3d2c3cd40ebce901d09a2479c267342e04e6f79c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mgronlun The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7937b3dc)
• 00: Full (a36ee311)

[mgronlun]

/integrate

[openjdk]

Going to push as commit 19eabaf.
Since your change was applied there have been 41 commits pushed to the master branch:

• 564066d: 8353118: Deprecate the use of java.locale.useOldISOCodes system property
• a1ab1d8: 8353449: [BACKOUT] One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683
• 2a31f69: 8353331: Test ForkJoinPool20Test::testFixedDelaySequence is failing
• 1809138: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files
• cef5610: 8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683
• 6801eb8: 8352709: Remove bad timing annotations from WhileOpTest.java
• 85a0baf: 8352719: Add an equals sign to the modules statement
• f25f701: 8353226: JFR: emit old object samples must be transitive closure complete for segment
• aff5aa7: 8350566: NMT: add size parameter to MemTracker::record_virtual_memory_tag
• 196334f: 8352046: Test testEcoFriendly() in jdk tools launcher ExecutionEnvironment.java for AIX and Linux/musl is brittle
• ... and 31 more: https://git.openjdk.org/jdk/compare/3d2c3cd40ebce901d09a2479c267342e04e6f79c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mgronlun Pushed as commit 19eabaf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.