8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException

[sendaoYan]

Hi all,

In test jdk/jfr/api/metadata/annotations/TestPeriod.java, the tested class PeriodicEvent extends Event, bug Event has three event types enabled/stackTrace/threshold by default. So we need to add period event type before test manually.

Change has been verified locally, test-fix only, no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException (Bug - P4)

Reviewers

• Erik Gahlin (@egahlin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24320/head:pull/24320
$ git checkout pull/24320

Update a local copy of the PR:
$ git checkout pull/24320
$ git pull https://git.openjdk.org/jdk.git pull/24320/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24320

View PR using the GUI difftool:
$ git pr show -t 24320

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24320.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• d4d1835: 8352860: Open source events tests batch0
• c9c3c15: 8330598: java/net/httpclient/Http1ChunkedTest.java fails with java.util.MissingFormatArgumentException: Format specifier '%s'
• 804a8fa: 8352765: G1CollectedHeap::expand_and_allocate() may fail to allocate even after heap expansion succeeds
• 22f630c: 8352415: x86: Tighten up template interpreter method entry code
• 6fbaa06: 8353176: C1: x86 patching stub always calls Thread::current()
• 79d0c94: 8352114: New test runtime/interpreter/CountBytecodesTest.java is failing
• 23e3b3f: 8351156: C1: Remove FPU stack support after 32-bit x86 removal
• 2592513: 8350577: Fix missing Assertion Predicates when splitting loops

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (30b96d85)

[sendaoYan]

Thanks for the review @egahlin.

I think I should integrate this PR now, to avoid test noisy of CI/CD. Do not wait 24 hours.

[sendaoYan]

/integrate

[openjdk]

Going to push as commit b7ca76e.
Since your change was applied there have been 9 commits pushed to the master branch:

• bbd5b17: 8339280: jarsigner -verify performs cross-checking between CEN and LOC
• d4d1835: 8352860: Open source events tests batch0
• c9c3c15: 8330598: java/net/httpclient/Http1ChunkedTest.java fails with java.util.MissingFormatArgumentException: Format specifier '%s'
• 804a8fa: 8352765: G1CollectedHeap::expand_and_allocate() may fail to allocate even after heap expansion succeeds
• 22f630c: 8352415: x86: Tighten up template interpreter method entry code
• 6fbaa06: 8353176: C1: x86 patching stub always calls Thread::current()
• 79d0c94: 8352114: New test runtime/interpreter/CountBytecodesTest.java is failing
• 23e3b3f: 8351156: C1: Remove FPU stack support after 32-bit x86 removal
• 2592513: 8350577: Fix missing Assertion Predicates when splitting loops

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit b7ca76e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.