8353330: Test runtime/cds/appcds/SignedJar.java fails in CDSHeapVerifier

[iklam]

Java core-lib changes in JDK-8339280 for code-signing causes more java.lang.invoke classes to be initialized in the assembly phase.

Static fields like java/lang/invoke/MethodHandleImpl$ArrayAccessor::OBJECT_ARRAY_SETTER are just cached MethodHandles whose object identity doesn't matter. So it's OK for them to be stored into the AOT cache. Therefore, I added them to the CDSHeapVerifier exclusion lists.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353330: Test runtime/cds/appcds/SignedJar.java fails in CDSHeapVerifier (Bug - P3)

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)
• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24363/head:pull/24363
$ git checkout pull/24363

Update a local copy of the PR:
$ git checkout pull/24363
$ git pull https://git.openjdk.org/jdk.git pull/24363/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24363

View PR using the GUI difftool:
$ git pr show -t 24363

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24363.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353330: Test runtime/cds/appcds/SignedJar.java fails in CDSHeapVerifier

Reviewed-by: vlivanov, dholmes, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 6970cf6: 8352775: JVM crashes with -XX:AOTMode=create -XX:+UseZGC
• afcad8c: 5043343: FileImageInputStream and FileImageOutputStream do not properly track streamPos for RandomAccessFile
• 6891490: 8353324: Clean up of comments and import after 8319192
• 07fd666: 8342984: Bump minimum boot jdk to JDK 24

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5f42b9d5)

[iwanowww]

Looks good.

// [D] Simple caches whose value doesn't matter.

Does the comment refer to "identity"?

[dholmes-ora]

Fix seems fine but I'm worried about how fragile this is. Any core-libs change might result in a change to the early loaded classes and break things again.

[liach]

Surprised they aren't caught earlier - they are used for spreader and collector forms that can easily appear in asType adaptions in plain invoke.

[iklam]

Thanks @iwanowww @dholmes-ora @dholmes-ora for the review
/integrate

[openjdk]

Going to push as commit 15d36ee.
Since your change was applied there have been 6 commits pushed to the master branch:

• e6fe249: 8323100: com/sun/tools/attach/StartManagementAgent.java failed with "WaitForSingleObject failed"
• 096e70d: 8352437: Support --add-exports with -XX:+AOTClassLinking
• 6970cf6: 8352775: JVM crashes with -XX:AOTMode=create -XX:+UseZGC
• afcad8c: 5043343: FileImageInputStream and FileImageOutputStream do not properly track streamPos for RandomAccessFile
• 6891490: 8353324: Clean up of comments and import after 8319192
• 07fd666: 8342984: Bump minimum boot jdk to JDK 24

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit 15d36ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.