8352620: C2: rename MemNode::memory_type() to MemNode::value_basic_type()

[sarannat]

Description: The current name MemNode::memory_type() is misleading because the returned type is a property of the value that is loaded/stored, not the memory that is accessed. Usually, the two of them match, but for mismatched memory accesses (arising e.g. from using Unsafe or memory segments) they might differ, e.g. one might store a value of type 'short' into an array of elements of type 'long'. The proposal was to rename MemNode::memory_type() to MemNode::value_basic_type() to clarify these cases.

Solution: Replaced all occurrence of MemNode::memory_type() with MemNode::value_basic_type()

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352620: C2: rename MemNode::memory_type() to MemNode::value_basic_type() (Enhancement - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer) Review applies to b9dfee3b
• Roberto Castañeda Lozano (@robcasloz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24427/head:pull/24427
$ git checkout pull/24427

Update a local copy of the PR:
$ git checkout pull/24427
$ git pull https://git.openjdk.org/jdk.git pull/24427/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24427

View PR using the GUI difftool:
$ git pr show -t 24427

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24427.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sarannat! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sarannat This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352620: C2: rename MemNode::memory_type() to MemNode::value_basic_type()

Reviewed-by: rcastanedalo, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 273 new commits pushed to the master branch:

• be6e440: 8349139: C2: Div looses dependency on condition that guarantees divisor not zero in counted loop
• 290d24d: 8355400: Better git detection in update_copyright_year.sh
• 84e9264: 8346552: C2: Add IR tests to check that Predicate cloning in Loop Unswitching works as expected
• ... and 270 more: https://git.openjdk.org/jdk/compare/7aeaa3c21c1420191fe8ff59e4cf99eae830754d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @robcasloz) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@sarannat The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (f0ef7ec8)
• 01: Full - Incremental (b9dfee3b)
• 00: Full (f2305491)

[robcasloz]

The value of this comment is debatable, but I think it is best to not remove it in this RFE (just rename memory_type to value_basic_type), to preserve the original scope of the RFE.

[TobiHartmann]

Looks good to me.

[eme64]

Suggested change

	//StoreP::value_basic_type() == T_ADDRESS
	// StoreP::value_basic_type() == T_ADDRESS

Nit: generally we have a space after the comment.

[sarannat]

/integrate

[openjdk]

@sarannat
Your change (at version f0ef7ec) is now ready to be sponsored by a Committer.

[robcasloz]

/sponsor

[openjdk]

Going to push as commit 74a2c83.
Since your change was applied there have been 273 commits pushed to the master branch:

• be6e440: 8349139: C2: Div looses dependency on condition that guarantees divisor not zero in counted loop
• 290d24d: 8355400: Better git detection in update_copyright_year.sh
• 84e9264: 8346552: C2: Add IR tests to check that Predicate cloning in Loop Unswitching works as expected
• ... and 270 more: https://git.openjdk.org/jdk/compare/7aeaa3c21c1420191fe8ff59e4cf99eae830754d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robcasloz @sarannat Pushed as commit 74a2c83.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sarannat]

Thank you for the review.