8344703: Compiler Implementation for Flexible Constructor Bodies

[mcimadamore]

This PR finalizes the Flexible Constructor Bodies feature with no semantics changes.
The main changes in this PR have to do with the various tests, which needed tweaking (e.g. to drop @enablePreview and fix corresponding golden files).

We might, later on, incorporate a fix for this issue into this PR, depending on where the specification for this feature lands.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8353435 to be approved
• Change requires a JEP request to be targeted

Issues

• JDK-8344703: Compiler Implementation for Flexible Constructor Bodies (Sub-task - P4)
• JDK-8344702: JEP 513: Flexible Constructor Bodies (JEP)
• JDK-8353435: Compiler Implementation for Flexible Constructor Bodies (CSR)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)
• Jan Lahoda (@lahodaj - Reviewer) Review applies to 2b06869f
• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24505/head:pull/24505
$ git checkout pull/24505

Update a local copy of the PR:
$ git checkout pull/24505
$ git pull https://git.openjdk.org/jdk.git pull/24505/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24505

View PR using the GUI difftool:
$ git pr show -t 24505

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24505.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344703: Compiler Implementation for Flexible Constructor Bodies

Reviewed-by: vromero, liach, jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

• c8a30c2: 8347004: vmTestbase/metaspace/shrink_grow/ShrinkGrowTest/ShrinkGrowTest.java fails with CDS disabled
• 90f0f1b: 8354443: [Graal] crash after deopt in TestG1BarrierGeneration.java
• d7e648b: 8355775: Improve symbolic sharing in dynamic constant pool entries
• ... and 42 more: https://git.openjdk.org/jdk/compare/def907ab89f3e5593aef17dcc61807e2836d41ae...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mcimadamore The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mcimadamore]

I did a bit of reshuffling here -- we had a single diagnostic test called PreviewFeatureUse which was only testing the warn.preview.feature.use.plural diagnostic. As a consequence, when I changed flexible constructor bodies to no longer be a preview feature, I started getting failures in CheckExamples because there was no test covering warn.preview.feature.use (e.g. w/o the trailing .plural). So I've added a test for both diagnostics (and renamed the old one to PreviewFeatureUsePlural).

[mlbridge]

Webrevs

• 01: Full (978e2254)
• 00: Full (2b06869f)

[vicente-romero-oracle]

lgtm

[lahodaj]

Looks good to me!

[lahodaj]

/jep JDK-8344702

[openjdk]

@lahodaj
This pull request will not be integrated until the JEP JDK-8344702 has been targeted.

[vicente-romero-oracle]

lgtm

[liach]

I think we should integrate at the current stage without waiting for anonymous or local class changes - those involve existing specification and is best done in their own RFEs.

[mcimadamore]

/integrate

[openjdk]

Going to push as commit c6ffacb.
Since your change was applied there have been 64 commits pushed to the master branch:

• 2ea629f: 8353440: Disable FTP fallback for non-local file URLs by default
• 57297e6: 8354278: Revert use of non-POSIX echo -n introduced in JDK-8301197
• 900b3ff: 8351359: OperatingSystemMXBean: values from getCpuLoad and getProcessCpuLoad are stale after 24.8 days (Windows)
• ... and 61 more: https://git.openjdk.org/jdk/compare/def907ab89f3e5593aef17dcc61807e2836d41ae...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mcimadamore Pushed as commit c6ffacb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.