-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8353592: Open source several scrollbar tests #24590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8353592: Open source several scrollbar tests #24590
Conversation
|
👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into |
|
@azvegint This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
honkar-jdk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from minor suggestions
| /* | ||
| * @test | ||
| * @bug 4029465 | ||
| * @summary Win95 Multiselect List doesn't display scrollbar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * @summary Win95 Multiselect List doesn't display scrollbar | |
| * @summary Win Multiselect List doesn't display scrollbar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep the original issue title.
|
|
||
| private static void scrollbarCheck(Point point, boolean isScrollbarExpected) { | ||
| Color pixelColor = robot.getPixelColor(point.x, point.y); | ||
| boolean areColorsSimilar = areColorsSimilar(BG_COLOR, pixelColor, 5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mino : tolerance can be declared as static final var
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it local as it is only used once.
azvegint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/integrate
| /* | ||
| * @test | ||
| * @bug 4029465 | ||
| * @summary Win95 Multiselect List doesn't display scrollbar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep the original issue title.
|
|
||
| private static void scrollbarCheck(Point point, boolean isScrollbarExpected) { | ||
| Color pixelColor = robot.getPixelColor(point.x, point.y); | ||
| boolean areColorsSimilar = areColorsSimilar(BG_COLOR, pixelColor, 5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it local as it is only used once.
|
Going to push as commit 5280b7b.
Your commit was automatically rebased without conflicts. |
Few scroll bar tests are open sourced. Testing looks good.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24590/head:pull/24590$ git checkout pull/24590Update a local copy of the PR:
$ git checkout pull/24590$ git pull https://git.openjdk.org/jdk.git pull/24590/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24590View PR using the GUI difftool:
$ git pr show -t 24590Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24590.diff
Using Webrev
Link to Webrev Comment