Skip to content

Conversation

@azvegint
Copy link
Member

@azvegint azvegint commented Apr 11, 2025

Few scroll bar tests are open sourced. Testing looks good.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353592: Open source several scrollbar tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24590/head:pull/24590
$ git checkout pull/24590

Update a local copy of the PR:
$ git checkout pull/24590
$ git pull https://git.openjdk.org/jdk.git pull/24590/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24590

View PR using the GUI difftool:
$ git pr show -t 24590

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24590.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2025

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 11, 2025

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353592: Open source several scrollbar tests

Reviewed-by: psadhukhan, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 11, 2025
@openjdk
Copy link

openjdk bot commented Apr 11, 2025

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 11, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 11, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 11, 2025
Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from minor suggestions

/*
* @test
* @bug 4029465
* @summary Win95 Multiselect List doesn't display scrollbar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @summary Win95 Multiselect List doesn't display scrollbar
* @summary Win Multiselect List doesn't display scrollbar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep the original issue title.


private static void scrollbarCheck(Point point, boolean isScrollbarExpected) {
Color pixelColor = robot.getPixelColor(point.x, point.y);
boolean areColorsSimilar = areColorsSimilar(BG_COLOR, pixelColor, 5);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mino : tolerance can be declared as static final var

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it local as it is only used once.

Copy link
Member Author

@azvegint azvegint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/integrate

/*
* @test
* @bug 4029465
* @summary Win95 Multiselect List doesn't display scrollbar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep the original issue title.


private static void scrollbarCheck(Point point, boolean isScrollbarExpected) {
Color pixelColor = robot.getPixelColor(point.x, point.y);
boolean areColorsSimilar = areColorsSimilar(BG_COLOR, pixelColor, 5);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it local as it is only used once.

@openjdk
Copy link

openjdk bot commented Apr 14, 2025

Going to push as commit 5280b7b.
Since your change was applied there have been 38 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 14, 2025
@openjdk openjdk bot closed this Apr 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 14, 2025
@openjdk
Copy link

openjdk bot commented Apr 14, 2025

@azvegint Pushed as commit 5280b7b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants