8354811: clock_tics_per_sec code duplication between os_linux and os_posix

[MBaesken]

Seems some of the clock_tics_per_sec code can be unified (e.g. in os_posix) between os_linux and os_posix.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354811: clock_tics_per_sec code duplication between os_linux and os_posix (Enhancement - P4)

Reviewers

• Andreas Steiner (@ansteiner - Author) Review applies to 5bc249ae
• Lutz Schmidt (@RealLucy - Reviewer)
• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24720/head:pull/24720
$ git checkout pull/24720

Update a local copy of the PR:
$ git checkout pull/24720
$ git pull https://git.openjdk.org/jdk.git pull/24720/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24720

View PR using the GUI difftool:
$ git pr show -t 24720

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24720.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354811: clock_tics_per_sec code duplication between os_linux and os_posix

Reviewed-by: lucy, clanger, asteiner

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 167 new commits pushed to the master branch:

• 21b0f5e: 8355637: SSLSessionImpl's "serialization" list documentation is incorrectly ordered
• 3b3a055: 8342676: Unsigned Vector Min / Max transforms
• 91a9043: 8355562: RISC-V: Cleanup names of vector-scalar instructions in riscv_v.ad
• ... and 164 more: https://git.openjdk.org/jdk/compare/1138a186eb670e2c0662bda69c35680b41f4d66c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (8c2e2b94)
• 00: Full (5bc249ae)

[MBaesken]

I noticed we have 2 usages here as well

jdk/src/hotspot/os/aix/os_perf_aix.cpp

Line 121 in 1138a18

static clock_t ticks_per_sec = sysconf(_SC_CLK_TCK);

Should I call the new method there too ?
On AIX it is clock_t (an int type, looking at the headers it is a typedef to 'int') .

[ansteiner]

Good that the code duplication was removed.

[RealCLanger]

I noticed we have 2 usages here as well

jdk/src/hotspot/os/aix/os_perf_aix.cpp

Line 121 in 1138a18

static clock_t ticks_per_sec = sysconf(_SC_CLK_TCK);

Should I call the new method there too ? On AIX it is clock_t (an int type, looking at the headers it is a typedef to 'int') .

Yes, I think it would make sense if AIX then used os::Posix::clock_tics_per_second() as well.

[RealCLanger]

I think you should rather not add clock_tics_factor but replace clock_tics_per_sec with os::Posix::clock_tics_per_second() in place, but it's maybe just a matter of taste...

[MBaesken]

Okay I change it.

[RealLucy]

Why use double here? The right hand side is an int expression and the use of clock_ticks_factor below is in a jlong expression yielding a jlong function result. If you want to avoid integer rounding, you have to cast at least one res operand to double.

[RealLucy]

LGTM now.

[RealCLanger]

LGTM now. Thanks for updating.

[MBaesken]

/integrate

[openjdk]

Going to push as commit 7df1bfe.
Since your change was applied there have been 174 commits pushed to the master branch:

• 40e7986: 8355611: Get rid of SurfaceManagerFactory
• 1f228e5: 8354119: Missing C2 proper allocation failure handling during initialization (during generate_uncommon_trap_blob)
• cd6f0d1: 8355336: GenShen: Resume Old GC even with back-to-back Young GC triggers
• ... and 171 more: https://git.openjdk.org/jdk/compare/1138a186eb670e2c0662bda69c35680b41f4d66c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 7df1bfe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.