Skip to content

Conversation

@turbanoff
Copy link
Member

@turbanoff turbanoff commented Apr 17, 2025

There is no need to call List.contains before List.remove call.
Instead we can use boolean value returned by List.remove


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24725/head:pull/24725
$ git checkout pull/24725

Update a local copy of the PR:
$ git checkout pull/24725
$ git pull https://git.openjdk.org/jdk.git pull/24725/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24725

View PR using the GUI difftool:
$ git pr show -t 24725

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24725.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 17, 2025

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@turbanoff The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 17, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2025

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 12, 2025

@turbanoff This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant