8356605: JRSUIControl.hashCode and JRSUIState.hashCode can use Long.hashCode

[wenshao]

Similar to #24959 and #24971 and #24987, apple.laf.JRSUIControl and apple.laf.JRSUIState in java.desktop can also be simplified similarly.

Replace manual bitwise operations in hashCode implementations of JRSUIControl/JRSUIState with Long::hashCode.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356605: JRSUIControl.hashCode and JRSUIState.hashCode can use Long.hashCode (Enhancement - P5)

Reviewers

• Phil Race (@prrace - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24989/head:pull/24989
$ git checkout pull/24989

Update a local copy of the PR:
$ git checkout pull/24989
$ git pull https://git.openjdk.org/jdk.git pull/24989/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24989

View PR using the GUI difftool:
$ git pr show -t 24989

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24989.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back swen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wenshao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356605: JRSUIControl.hashCode and JRSUIState.hashCode can use Long.hashCode

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 184 new commits pushed to the master branch:

• 303f410: 8355708: Two Float16 IR tests fail after JDK-8345125
• c23469d: 8355340: GenShen: Remove unneeded log messages related to remembered set write table
• b6b5ac1: 8348351: Improve lazy initialization of the available currencies set
• ... and 181 more: https://git.openjdk.org/jdk/compare/bee273d6b4e34692952d4e7474ab72ee5c54e33a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@wenshao The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2ea4493d)

[prrace]

I'm not entirely convinced this "simplification" was worth anyone's time to understand and review. I've run tests and I don't see any failures, but it wasn't likely something we have a test for.
You'll need to fix the PR name

[prrace]

Since this uses Double.hashCode() not Long.hashCode() it would have been nice to have some comments on that. It took a bit of reading and following to learn that Double.hashCode() first uses Double.doubleToRawLongBits and then calls out to Long.hashCode

[wenshao]

Double.hashCode is a simple call, and there are no comments in other places where Double.hashCode is used in the JDK source code.

[wenshao]

I'm not entirely convinced this "simplification" was worth anyone's time to understand and review. I've run tests and I don't see any failures, but it wasn't likely something we have a test for. You'll need to fix the PR name

@pprace, thank you for reviewing this PR. I will follow your advice and will not submit similar PRs in the client module.

[wenshao]

/integrate

[openjdk]

Going to push as commit 1bded71.
Since your change was applied there have been 212 commits pushed to the master branch:

• 89242ee: 8356885: Don't emit C1 profiling for casts if TypeProfileCasts is off
• e149bd3: 8352755: Misconceptions about j.text.DecimalFormat digits during parsing
• e7ce661: 8356667: GenShen: Eliminate races with ShenandoahFreeSet::available()
• ... and 209 more: https://git.openjdk.org/jdk/compare/bee273d6b4e34692952d4e7474ab72ee5c54e33a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wenshao Pushed as commit 1bded71.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.