8356021: Use Double::hashCode in java.util.Locale::hashCode

[wenshao]

Similar to #24959, java.util.Locale.hashCode can also make the same improvement.

Replace manual bitwise operations in hashCode implementations of java.util.Locale with Double::hashCode.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356021: Use Double::hashCode in java.util.Locale::hashCode (Enhancement - P4)

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)
• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24971/head:pull/24971
$ git checkout pull/24971

Update a local copy of the PR:
$ git checkout pull/24971
$ git pull https://git.openjdk.org/jdk.git pull/24971/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24971

View PR using the GUI difftool:
$ git pr show -t 24971

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24971.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back swen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wenshao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356021: Use Double::hashCode in java.util.Locale::hashCode

Reviewed-by: rriggs, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 34807df: 8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension
• 7b31762: 8354235: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine
• 0cd0afb: 8355913: RISC-V: improve hotspot/jtreg/compiler/vectorization/runner/BasicFloatOpTest.java
• ... and 11 more: https://git.openjdk.org/jdk/compare/18983b635fe3469c1d9060611eee76e0155ba21b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@wenshao The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d35b5b6a)

[RogerRiggs]

lgltm

[liach]

Thanks for this cleanup, indeed equivalent.

[wenshao]

/integrate

[openjdk]

Going to push as commit 2ad639f.
Since your change was applied there have been 15 commits pushed to the master branch:

• bee273d: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version
• 34807df: 8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension
• 7b31762: 8354235: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine
• ... and 12 more: https://git.openjdk.org/jdk/compare/18983b635fe3469c1d9060611eee76e0155ba21b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wenshao Pushed as commit 2ad639f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[naotoj]

Thanks for the fix. Even though the fix is trivial and small, please keep the PR open at least for 24 hours so that every region of the globe can see the fix.

[wenshao]

@naotoj Thank you for your reminder. There is a problem with GitHub's prompt. It shows yesterday in less than 24 hours. I will avoid this problem next time.