8357013: HttpURLConnection#getResponseCode can avoid substring call when parsing to int

[kilink]

Avoid allocating a substring to parse the response code in HttpURLConnection#getResponseCode, but instead use the Integer.parseInt overload that accepts String indices.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357013: HttpURLConnection#getResponseCode can avoid substring call when parsing to int (Enhancement - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25245/head:pull/25245
$ git checkout pull/25245

Update a local copy of the PR:
$ git checkout pull/25245
$ git pull https://git.openjdk.org/jdk.git pull/25245/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25245

View PR using the GUI difftool:
$ git pr show -t 25245

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25245.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kilink! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kilink This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357013: HttpURLConnection#getResponseCode can avoid substring call when parsing to int

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 104 new commits pushed to the master branch:

• bcf5cd6: 8355954: File.delete removes read-only files (win)
• 6162e2c: 8357062: Update Public Suffix List to 823beb1
• 62d155e: 8355230: Crash in fuzzer tests: assert(n != nullptr) failed: must not be null
• ... and 101 more: https://git.openjdk.org/jdk/compare/89242eecd2f381608f78bd8c431eca389956e79a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@kilink The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b2d42d35)

[dfuch]

Thanks for this fix. The proposed changes LGTM. Did you run tier2 tests?

[kilink]

Thanks for this fix. The proposed changes LGTM. Did you run tier2 tests?

Yes, I've run tier1 and tier2 tests. There were a few unrelated failures, but the test that covers this change passed.

[dfuch]

Thanks @kilink ; As a measure of safety I have run tier1 and tier2 against these changes in our CI as well and have observed no related failure. I'm going to approve now.

[kilink]

/integrate

[openjdk]

@kilink
Your change (at version b2d42d3) is now ready to be sponsored by a Committer.

[dfuch]

/sponsor

[openjdk]

Going to push as commit e9d1d87.
Since your change was applied there have been 104 commits pushed to the master branch:

• bcf5cd6: 8355954: File.delete removes read-only files (win)
• 6162e2c: 8357062: Update Public Suffix List to 823beb1
• 62d155e: 8355230: Crash in fuzzer tests: assert(n != nullptr) failed: must not be null
• ... and 101 more: https://git.openjdk.org/jdk/compare/89242eecd2f381608f78bd8c431eca389956e79a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch @kilink Pushed as commit e9d1d87.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.