8356706: Foreign tests timeout after passing on linux-x64-zero #25248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minborg
commented
May 15, 2025
| static final class StdLibHelper { | ||
|
|
||
| final static MethodHandle strcat = abi.downcallHandle(abi.defaultLookup().find("strcat").get(), | ||
| static final MethodHandle strcat = abi.downcallHandle(abi.defaultLookup().findOrThrow("strcat"), |
Contributor
Author
There was a problem hiding this comment.
Drive-by cleanup to blessed order.
|
👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into |
minborg
commented
May 15, 2025
| static final Linker abi = Linker.nativeLinker(); | ||
|
|
||
| private StdLibHelper stdLibHelper = new StdLibHelper(); | ||
| private static final StdLibHelper STD_LIB_HELPER = new StdLibHelper(); |
Contributor
Author
There was a problem hiding this comment.
The STD_LIB_HELPER is now a constant.
|
❗ This change is not yet ready to be integrated. |
Contributor
Author
|
I am closing this PR without integrating, as it has been fixed elsewhere (see issue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the robustness of tests on slow machines such as "zero" variants. The timeout was increased to 10 minutes for both tests. There are many combinations in
TestAccessModes, so the test takes some time even on a fast machine. InStdLibTest, there are numerous native calls, and these can be much slower on "zero" machines. In the latter test class, I made some attempts to improve performance. On my M1 machine, the test was about 10% faster with the changes (but I only did one run, so this might be in the error margin).Progress
Issue
Backport <hash>with the hash of the original commit. See Backports.Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25248/head:pull/25248$ git checkout pull/25248Update a local copy of the PR:
$ git checkout pull/25248$ git pull https://git.openjdk.org/jdk.git pull/25248/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25248View PR using the GUI difftool:
$ git pr show -t 25248Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25248.diff
Using Webrev
Link to Webrev Comment