Skip to content

Conversation

@ArnoZeller
Copy link
Contributor

@ArnoZeller ArnoZeller commented May 15, 2025

When the test java/io/File/GetXSpace.java fails, because the usable space is greater than the free space, the values in the exception are not the correct ones.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357052: java/io/File/GetXSpace.java prints wrong values in exception (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25250/head:pull/25250
$ git checkout pull/25250

Update a local copy of the PR:
$ git checkout pull/25250
$ git pull https://git.openjdk.org/jdk.git pull/25250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25250

View PR using the GUI difftool:
$ git pr show -t 25250

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25250.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2025

👋 Welcome back azeller! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 15, 2025

@ArnoZeller This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357052: java/io/File/GetXSpace.java prints wrong values in exception

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bplb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented May 15, 2025

@ArnoZeller The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 15, 2025
@ArnoZeller ArnoZeller marked this pull request as ready for review May 16, 2025 10:33
@openjdk openjdk bot added the rfr Pull request is ready for review label May 16, 2025
@mlbridge
Copy link

mlbridge bot commented May 16, 2025

Webrevs

Copy link
Member

@bplb bplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 16, 2025
@bplb
Copy link
Member

bplb commented May 19, 2025

@ArnoZeller Please issue the /integrate command so that this request may be sponsored.

@ArnoZeller
Copy link
Contributor Author

@ArnoZeller Please issue the /integrate command so that this request may be sponsored.

Thanks for reviewing!

@ArnoZeller
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 20, 2025
@openjdk
Copy link

openjdk bot commented May 20, 2025

@ArnoZeller
Your change (at version 8506932) is now ready to be sponsored by a Committer.

@sendaoYan
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 20, 2025

Going to push as commit f8fc7ee.
Since your change was applied there have been 58 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 20, 2025
@openjdk openjdk bot closed this May 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 20, 2025
@openjdk
Copy link

openjdk bot commented May 20, 2025

@sendaoYan @ArnoZeller Pushed as commit f8fc7ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants