8347530: Improve error message with invalid permits clauses

[biboudis]

Currently we report one kind of error message (subclass {0} must extend sealed class) when there is a compile-type error in cases like the following:

sealed class C0 permits S0 {}
class S0 {}  

This PR proposes to improve error reporting since there are other kinds of declarations that can also participate in sealed hierarchies like records, enums and interfaces.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347530: Improve error message with invalid permits clauses (Bug - P4)

Reviewers

• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25255/head:pull/25255
$ git checkout pull/25255

Update a local copy of the PR:
$ git checkout pull/25255
$ git pull https://git.openjdk.org/jdk.git pull/25255/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25255

View PR using the GUI difftool:
$ git pr show -t 25255

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25255.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347530: Improve error message with invalid permits clauses

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• 079fccf: 8353888: Implement JEP 510: Key Derivation Function API
• 0d86757: 8355488: Add stress mode for C2 loop peeling
• a0a3060: 8353638: C2: deoptimization and re-execution cycle with StringBuilder
• ... and 16 more: https://git.openjdk.org/jdk/compare/5cb231714f364064bb5a59db8eb07d43823478eb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@biboudis The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (4fb2f9af)
• 00: Full (3195b3ad)

[lahodaj]

Looks good to me!

[biboudis]

/integrate

[openjdk]

Going to push as commit 50a7755.
Since your change was applied there have been 71 commits pushed to the master branch:

• 50e873f: 8356455: ZGC: Replace ZIntrusiveRBTree with IntrusiveRBTree
• 74fc4e4: 8357179: Deprecate VFORK launch mechanism from Process implementation (linux)
• cedd1a5: 8357250: assert(shift >= 0 && shift < 4) failed: unexpected compressd klass shift!
• ... and 68 more: https://git.openjdk.org/jdk/compare/5cb231714f364064bb5a59db8eb07d43823478eb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@biboudis Pushed as commit 50a7755.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.