Skip to content

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented May 15, 2025

Removing now-defunct COMPAT locale provider tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357075: Remove leftover COMPAT locale data tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25257/head:pull/25257
$ git checkout pull/25257

Update a local copy of the PR:
$ git checkout pull/25257
$ git pull https://git.openjdk.org/jdk.git pull/25257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25257

View PR using the GUI difftool:
$ git pr show -t 25257

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25257.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2025

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 15, 2025

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357075: Remove leftover COMPAT locale data tests

Reviewed-by: joehw, iris, jlu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 15, 2025
@openjdk
Copy link

openjdk bot commented May 15, 2025

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels May 15, 2025
@mlbridge
Copy link

mlbridge bot commented May 15, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 15, 2025
Copy link
Member

@justin-curtis-lu justin-curtis-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup; lgtm

naotoj and others added 3 commits May 15, 2025 13:49
Co-authored-by: Justin Lu <Justin.lu@oracle.com>
Co-authored-by: Justin Lu <Justin.lu@oracle.com>
Co-authored-by: Justin Lu <Justin.lu@oracle.com>
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 15, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 16, 2025
@naotoj
Copy link
Member Author

naotoj commented May 16, 2025

Thanks for the reviews!
/integrate

@openjdk
Copy link

openjdk bot commented May 16, 2025

Going to push as commit 3dd3451.
Since your change was applied there have been 62 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 16, 2025
@openjdk openjdk bot closed this May 16, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 16, 2025
@openjdk
Copy link

openjdk bot commented May 16, 2025

@naotoj Pushed as commit 3dd3451.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants