8357079: Fix Windows AArch64 DevKit Creation

[Luigi96]

Fix path for Visual Studio arm64 binaries in createWindowsDevkit.sh

The DevKit currently created on a Windows AArch64 machine uses the x64 compiler binaries (e.g. cl.exe). This can be inspected by running "dumpbin /headers /out:cl.txt cl.exe" on the compiler in the generated DevKit and inspecting the machine architecture line. It should instead use the native Windows AArch64 compiler binaries

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357079: Fix Windows AArch64 DevKit Creation (Enhancement - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25259/head:pull/25259
$ git checkout pull/25259

Update a local copy of the PR:
$ git checkout pull/25259
$ git pull https://git.openjdk.org/jdk.git pull/25259/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25259

View PR using the GUI difftool:
$ git pr show -t 25259

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25259.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @Luigi96, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Luigi96" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[Luigi96]

/covered

[openjdk]

@Luigi96 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357079: Fix Windows AArch64 DevKit Creation

Reviewed-by: erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 772 new commits pushed to the master branch:

• 8ea544c: 8360287: JFR: PlatformTracer class should be loaded lazily
• 334683e: 8358645: Access violation in ThreadsSMRSupport::print_info_on during thread dump
• 20e0055: 8344165: Trace exceptions with a complete call-stack
• ... and 769 more: https://git.openjdk.org/jdk/compare/24d84cf66a47e10002a836275794f3f17e147c99...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @magicus) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[openjdk]

@Luigi96 The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (1da82324)
• 00: Full (305540ce)

[bridgekeeper]

@Luigi96 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[Luigi96]

/touch

[openjdk]

@Luigi96 The pull request is being re-evaluated and the inactivity timeout has been reset.

[erikj79]

I think this is ok for now, but ideally we should either make a single devkit that can cross and native compile on both host archs, or explicitly create two different ones, one for each host arch.

[magicus]

It looks good to me now. Let's see if @erikj79 has some additional input.

[erikj79]

This looks great, thanks!

[Luigi96]

/integrate

[openjdk]

@Luigi96
Your change (at version 1da8232) is now ready to be sponsored by a Committer.

[erikj79]

/sponsor

[openjdk]

Going to push as commit 6d05a1d.
Since your change was applied there have been 772 commits pushed to the master branch:

• 8ea544c: 8360287: JFR: PlatformTracer class should be loaded lazily
• 334683e: 8358645: Access violation in ThreadsSMRSupport::print_info_on during thread dump
• 20e0055: 8344165: Trace exceptions with a complete call-stack
• ... and 769 more: https://git.openjdk.org/jdk/compare/24d84cf66a47e10002a836275794f3f17e147c99...master

Your commit was automatically rebased without conflicts.

[openjdk]

@erikj79 @Luigi96 Pushed as commit 6d05a1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.