Skip to content

Conversation

@sormuras
Copy link
Member

@sormuras sormuras commented May 16, 2025

Please review the change to update to using jtreg 7.5.2.

The primary change is to the jib-profiles.js file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the requiredVersion has been updated in the various TEST.ROOT files.

Tested with tier 1 — tier 8.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357141: Update to use jtreg 7.5.2 (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25263/head:pull/25263
$ git checkout pull/25263

Update a local copy of the PR:
$ git checkout pull/25263
$ git pull https://git.openjdk.org/jdk.git pull/25263/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25263

View PR using the GUI difftool:
$ git pr show -t 25263

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25263.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2025

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 16, 2025

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357141: Update to use jtreg 7.5.2

Reviewed-by: erikj, ihse, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 253 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 16, 2025

@sormuras The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label May 16, 2025
@sormuras sormuras marked this pull request as ready for review May 22, 2025 10:40
@openjdk openjdk bot added the rfr Pull request is ready for review label May 22, 2025
@mlbridge
Copy link

mlbridge bot commented May 22, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 22, 2025
@shipilev
Copy link
Member

I see a few major JEPs lined up for JDK 25 integration. I'd prefer to wait for this until after JDK 25 fork. That is, we can still put it into JDK 25 stabilization tree, just after everyone complete their integrate-merge-retest rush for JDK 25.

@sormuras
Copy link
Member Author

Test runs through tier 1 to 8 show that only few unrelated tests do fail at the moment, thus the impact of updating to use jtreg 7.5.2 in the current phase is minimal. Except for provisioning the new tool version - which might put more stress to some teams compared to others.

Integration after JDK 25-ea entering RDP1 is an option.

@sormuras
Copy link
Member Author

Targeted to JDK 26 now.

@sormuras
Copy link
Member Author

sormuras commented Jun 5, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jun 5, 2025

Going to push as commit fe3be49.
Since your change was applied there have been 254 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 5, 2025
@openjdk openjdk bot closed this Jun 5, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 5, 2025
@openjdk
Copy link

openjdk bot commented Jun 5, 2025

@sormuras Pushed as commit fe3be49.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

5 participants