Skip to content

8365732: RISC-V: implement AES CTR intrinsics #25281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Anjian-Wen wants to merge 31 commits into from
Closed

8365732: RISC-V: implement AES CTR intrinsics #25281

Anjian-Wen wants to merge 31 commits into from

Conversation

@Anjian-Wen
Copy link
Contributor

@Anjian-Wen Anjian-Wen commented May 17, 2025 •
edited by openjdk bot
Loading

Hi everyone, please help review this patch which Implement the _counterMode_AESCrypt with Zvkned. On my QEMU, with Zvkned extension enabled, the tests in test/hotspot/jtreg/compiler/codegen/aes/ Passed.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8365732: RISC-V: implement AES CTR intrinsics (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25281/head:pull/25281
$ git checkout pull/25281

Update a local copy of the PR:
$ git checkout pull/25281
$ git pull https://git.openjdk.org/jdk.git pull/25281/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25281

View PR using the GUI difftool:
$ git pr show -t 25281

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25281.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2025

👋 Welcome back Anjian-Wen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 17, 2025 •
edited
Loading

@Anjian-Wen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365732: RISC-V: implement AES CTR intrinsics

Reviewed-by: fyang, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 73 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @Hamlin-Li) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented May 17, 2025 •
edited
Loading

@Anjian-Wen The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 17, 2025
@Anjian-Wen Anjian-Wen force-pushed the aes_ctr branch 2 times, most recently from 96e6b4f to 32c0130 Compare June 19, 2025 07:06
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2025

@Anjian-Wen This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@Anjian-Wen
Copy link
Contributor Author

Anjian-Wen commented Jul 14, 2025

still working on it.

/keepalive

@openjdk
Copy link

openjdk bot commented Jul 14, 2025

@Anjian-Wen The pull request is being re-evaluated and the inactivity timeout has been reset.

@Anjian-Wen Anjian-Wen force-pushed the aes_ctr branch 3 times, most recently from bbdf934 to 45ab44c Compare July 14, 2025 08:51
theRealAph
theRealAph reviewed Jul 15, 2025
View reviewed changes
@Anjian-Wen Anjian-Wen changed the title RISC-V: implement AES-CTR mode intrinsics RISC-V: implement AES-CTR mode intrinsics [WIP] Jul 31, 2025
@Anjian-Wen
Copy link
Contributor Author

Anjian-Wen commented Aug 5, 2025

Pass the aes-ctr test in jtreg:test/hotspot/jtreg/compiler/codegen/aes

Test in qemu-sys-riscv64, with extension v=true,zvkn=true,zvkned=true,zvknc=true,zvkng=true

@Anjian-Wen Anjian-Wen marked this pull request as ready for review August 5, 2025 04:52
@Anjian-Wen Anjian-Wen changed the title RISC-V: implement AES-CTR mode intrinsics [WIP] RISC-V: implement AES-CTR mode intrinsics Aug 19, 2025
@Anjian-Wen
Copy link
Contributor Author

Anjian-Wen commented Aug 19, 2025

/issue JDK-8365732

@openjdk openjdk bot changed the title RISC-V: implement AES-CTR mode intrinsics 8365732: RISC-V: implement AES CTR intrinsics Aug 19, 2025
@openjdk
Copy link

openjdk bot commented Aug 19, 2025

@Anjian-Wen The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 19, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 19, 2025 •
edited
Loading

Webrevs

RealFYang
RealFYang reviewed Aug 28, 2025
View reviewed changes
Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thanks for making these changes. I am having a look and I have some minor comments along the way.

Hamlin-Li
Hamlin-Li reviewed Nov 18, 2025
View reviewed changes
Hamlin-Li
Hamlin-Li reviewed Nov 18, 2025
View reviewed changes
Hamlin-Li
Hamlin-Li reviewed Nov 18, 2025
View reviewed changes
Hamlin-Li
Hamlin-Li reviewed Nov 18, 2025
View reviewed changes
Hamlin-Li
Hamlin-Li reviewed Nov 18, 2025
View reviewed changes
Hamlin-Li
Hamlin-Li reviewed Nov 18, 2025
View reviewed changes
Hamlin-Li
Hamlin-Li reviewed Nov 18, 2025
View reviewed changes
Hamlin-Li
Hamlin-Li reviewed Nov 18, 2025
View reviewed changes
Copy link

@Hamlin-Li Hamlin-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments and questions.

@Anjian-Wen
Copy link
Contributor Author

Anjian-Wen commented Nov 19, 2025

Some more comments and questions.

Thanks for the careful reviews! I will check the comments and reply one by one later

@Hamlin-Li
Copy link

Hamlin-Li commented Nov 19, 2025

Some more comments and questions.

Thanks for the careful reviews! I will check the comments and reply one by one later

Thanks! Overall looks good, I'll have another by this weekend. Thanks for your patience!

@Anjian-Wen
Copy link
Contributor Author

Anjian-Wen commented Dec 2, 2025

@Hamlin-Li Thanks, I have modified some code according to your suggestions and replied to all the comments. Could you please help review it again when you have time? : )

Some more comments and questions.

Thanks for the careful reviews! I will check the comments and reply one by one later

Thanks! Overall looks good, I'll have another by this weekend. Thanks for your patience!

Hamlin-Li
Hamlin-Li reviewed Dec 2, 2025
View reviewed changes
Hamlin-Li
Hamlin-Li approved these changes Dec 3, 2025
View reviewed changes
Copy link

@Hamlin-Li Hamlin-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks!

RealFYang
RealFYang approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 4, 2025
@Anjian-Wen
Copy link
Contributor Author

Anjian-Wen commented Dec 5, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 5, 2025
@openjdk
Copy link

openjdk bot commented Dec 5, 2025

@Anjian-Wen
Your change (at version 98d802d) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

RealFYang commented Dec 5, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 5, 2025

Going to push as commit 7e91d34.
Since your change was applied there have been 73 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 5, 2025
@openjdk openjdk bot closed this Dec 5, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 5, 2025
@openjdk
Copy link

openjdk bot commented Dec 5, 2025

@RealFYang @Anjian-Wen Pushed as commit 7e91d34.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@theRealAph theRealAph theRealAph left review comments

@Hamlin-Li Hamlin-Li Hamlin-Li approved these changes

@RealFYang RealFYang RealFYang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Anjian-Wen @RealFYang @Hamlin-Li @theRealAph