8359428: Test 'javax/swing/JTabbedPane/bug4499556.java' failed because after selecting one of L&F items, the test case automatically failed when clicking on L&F Menu button again

[prsadhuk]

It is seen that this test (which was opensourced in JDK-8353304) when run with NimbusLookAndFeel, after selecting one of L&F items, the test case automatically failed when clicking on L&F Menu button again.
It is because while switching to another L&F say platform(WindowsL&F) from Metal/Nimbus LookAndFeel, if testcase was originally run in Nimbus L&F, SynthMenuItemLayoutHelper() calls MenuItemLayoutHelper.reset where style.getFont(context) return null font so when it calls getFontMetrics(font) it calls font.hashCode which fails with

Execution failed: `main' threw exception: java.lang.NullPointerException: Cannot invoke "java.awt.Font.hashCode()" because "font" is null

This is happening because the test calls SwingUtilities.updateComponentTreeUI on tabbedpane.
So, when L&F is changed inside the test via "L&F Menu" option 1st time say Metal to Platform, it changes the L&F of the tabbed pane to Windows L&F, but not for the "L&F Menu" font itself which is still in Nimbus L&F, but style context is reset so when next time "L&F Menu" is clicked to change the L&F, SynthMenuItemLayoutHelper gets null font from invalid context and then it crashes.
Fix is to ensure the updateComponentTreeUI should be for entire frame which consists of "L&F Menu" and the tabs so L&F is changed consistently for all nodes.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8359428: Test 'javax/swing/JTabbedPane/bug4499556.java' failed because after selecting one of L&F items, the test case automatically failed when clicking on L&F Menu button again (Bug - P4)

Reviewers

• Abhishek Kumar (@kumarabhi006 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25822/head:pull/25822
$ git checkout pull/25822

Update a local copy of the PR:
$ git checkout pull/25822
$ git pull https://git.openjdk.org/jdk.git pull/25822/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25822

View PR using the GUI difftool:
$ git pr show -t 25822

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25822.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359428: Test 'javax/swing/JTabbedPane/bug4499556.java' failed because after selecting one of L&F items, the test case automatically failed when clicking on L&F Menu button again

Reviewed-by: abhiscxk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 1130c1b: 6798061: The removal of System.out.println from KeyboardManager
• 2f63d3a: 7116990: (spec) Socket.connect(addr,timeout) not clear if IOException because of TCP timeout
• 382f870: 8357976: GenShen crash in swap_card_tables: Should be clean
• ... and 24 more: https://git.openjdk.org/jdk/compare/79497ef7f55ef445b31348ae9d3d6dff6d3b6a54...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[prsadhuk]

/touch

[openjdk]

@prsadhuk The pull request is being re-evaluated and the inactivity timeout has been reset.

[mlbridge]

Webrevs

• 00: Full (656ad594)

[lawrence-andrew]

LGTM

[prsadhuk]

Any reviewers?

[kumarabhi006]

Verified the fix on mac machine and it behaves correct with the fix.

[prsadhuk]

/integrate

[openjdk]

Going to push as commit 2b94b70.
Since your change was applied there have been 27 commits pushed to the master branch:

• 1130c1b: 6798061: The removal of System.out.println from KeyboardManager
• 2f63d3a: 7116990: (spec) Socket.connect(addr,timeout) not clear if IOException because of TCP timeout
• 382f870: 8357976: GenShen crash in swap_card_tables: Should be clean
• ... and 24 more: https://git.openjdk.org/jdk/compare/79497ef7f55ef445b31348ae9d3d6dff6d3b6a54...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit 2b94b70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.